[GitHub] [doris] xinyiZzz commented on a diff in pull request #20066: [fix](resource-group) Fix resource group memory isolation may release too much memory

["xinyiZzz (via GitHub)" <gi...@apache.org>]

xinyiZzz commented on code in PR #20066:
URL: https://github.com/apache/doris/pull/20066#discussion_r1205529050


##########
be/src/runtime/query_context.h:
##########
@@ -109,6 +109,9 @@ class QueryContext {
             _is_cancelled = is_cancelled;
             _ready_to_execute = true;
         }
+        if (query_mem_tracker && is_cancelled) {
+            query_mem_tracker->set_is_query_cancelled(is_cancelled);

Review Comment:
   Why here, not in `PlanFragmentExecutor::cancel` and `PipelineFragmentContext::cancel`
   
   seems to break the meaning of `set_ready_to_execute`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org