You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "wjones127 (via GitHub)" <gi...@apache.org> on 2023/05/08 16:23:12 UTC
[GitHub] [arrow] wjones127 opened a new pull request, #35484: GH-35483: [CI][C++] Add header for snprintf for Windows
wjones127 opened a new pull request, #35484:
URL: https://github.com/apache/arrow/pull/35484
### Rationale for this change
Fixing failing nightlies.
### What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
### Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
### Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wjones127 commented on pull request #35484: GH-35483: [CI][C++] Add header for snprintf for Windows
Posted by "wjones127 (via GitHub)" <gi...@apache.org>.
wjones127 commented on PR #35484:
URL: https://github.com/apache/arrow/pull/35484#issuecomment-1538839969
@github-actions crossbow submit conda-win-x64-cpu-r41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35484: GH-35483: [CI][C++] Add header for snprintf for Windows
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35484:
URL: https://github.com/apache/arrow/pull/35484#issuecomment-1541048747
@github-actions crossbow submit conda-win-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35484: GH-35483: [CI][C++] Add header for snprintf for Windows
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35484:
URL: https://github.com/apache/arrow/pull/35484#issuecomment-1541321319
Ah, I should have changed the PR title before I merge this...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35484: GH-35483: [CI][C++] Add header for snprintf for Windows
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35484:
URL: https://github.com/apache/arrow/pull/35484#issuecomment-1538690716
Revision: e6270fe78f3e8d60b1540f19081bc7d37a4d774e
Submitted crossbow builds: [ursacomputing/crossbow @ actions-5e14f30950](https://github.com/ursacomputing/crossbow/branches/all?query=actions-5e14f30950)
|Task|Status|
|----|------|
|conda-win-x64-cpu-py3|[](https://github.com/ursacomputing/crossbow/runs/13318764968)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35484: GH-35483: [CI][C++] Add header for snprintf for Windows
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35484:
URL: https://github.com/apache/arrow/pull/35484#issuecomment-1541050905
Revision: 265b1304c343a2870027e5774a0c7a48e3240982
Submitted crossbow builds: [ursacomputing/crossbow @ actions-aa3397135f](https://github.com/ursacomputing/crossbow/branches/all?query=actions-aa3397135f)
|Task|Status|
|----|------|
|conda-win-x64-cpu-py3|[](https://github.com/ursacomputing/crossbow/runs/13359759519)|
|conda-win-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/13359758351)|
|conda-win-x64-cuda-py3|[](https://github.com/ursacomputing/crossbow/runs/13359759092)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #35484: GH-35483: [CI][C++] Add header for snprintf for Windows
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #35484:
URL: https://github.com/apache/arrow/pull/35484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35484: GH-35483: [CI][C++] Add header for snprintf for Windows
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35484:
URL: https://github.com/apache/arrow/pull/35484#issuecomment-1542695517
Benchmark runs are scheduled for baseline = 122fc86576b03ebd130e027200c5eda6a185d2ee and contender = e9b9042a058333b68849a640b510e94413a29d91. e9b9042a058333b68849a640b510e94413a29d91 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/6af7ac69d97c469a91c2ba7b0ef97fd6...8c337ab41b0143f8946f7716ed71c3ce/)
[Finished :arrow_down:4.71% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/25d83336b5734cbbad89c5b7e57188ed...fb01cbd502d04658bba4c8c30991df34/)
[Finished :arrow_down:0.51% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/1e1f3ab12056441ea590e71a2ad11bda...3ccb0243ccd649f189f4f0cc10e22af2/)
[Finished :arrow_down:0.54% :arrow_up:0.06%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/c8b25b1ffa5240c79d96a39fd9b0971c...8ff326ab994c49b48f8e4e98e0fa8132/)
Buildkite builds:
[Finished] [`e9b9042a` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2843)
[Finished] [`e9b9042a` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2879)
[Finished] [`e9b9042a` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2844)
[Finished] [`e9b9042a` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2869)
[Finished] [`122fc865` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2842)
[Finished] [`122fc865` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2878)
[Finished] [`122fc865` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2843)
[Finished] [`122fc865` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2868)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35484: GH-35483: [CI][C++] Add header for snprintf for Windows
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35484:
URL: https://github.com/apache/arrow/pull/35484#issuecomment-1538845382
Revision: c63a14533891291a801bb19ce439f171161a6bcc
Submitted crossbow builds: [ursacomputing/crossbow @ actions-cd861e1a50](https://github.com/ursacomputing/crossbow/branches/all?query=actions-cd861e1a50)
|Task|Status|
|----|------|
|conda-win-x64-cpu-r41|[](https://github.com/ursacomputing/crossbow/runs/13321770302)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wjones127 commented on pull request #35484: GH-35483: [CI][C++] Add header for snprintf for Windows
Posted by "wjones127 (via GitHub)" <gi...@apache.org>.
wjones127 commented on PR #35484:
URL: https://github.com/apache/arrow/pull/35484#issuecomment-1538686234
@github-actions crossbow submit conda-win-x64-cpu-py3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #35484: GH-35483: [CI][C++] Add header for snprintf for Windows
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #35484:
URL: https://github.com/apache/arrow/pull/35484#discussion_r1187993559
##########
python/pyarrow/src/arrow/python/platform.h:
##########
@@ -32,5 +32,10 @@
#if _MSC_VER >= 1900
#undef timezone
#endif
+
+// https://bugs.python.org/issue36020
+#if _MSC_VER >= 1500
+#undef snprintf
+#endif
Review Comment:
It seems that the macro was removed by https://github.com/python/cpython/commit/e822e37946f27c09953bb5733acf3b07c2db690f .
How about the following?
```cpp
#ifdef snprintf
#undef snprintf
#endif
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35484: GH-35483: [CI][C++] Add header for snprintf for Windows
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35484:
URL: https://github.com/apache/arrow/pull/35484#issuecomment-1538683851
* Closes: #35483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35484: GH-35483: [CI][C++] Add header for snprintf for Windows
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35484:
URL: https://github.com/apache/arrow/pull/35484#issuecomment-1542701714
['Python', 'R'] benchmarks have high level of regressions.
[test-mac-arm](https://conbench.ursa.dev/compare/runs/25d83336b5734cbbad89c5b7e57188ed...fb01cbd502d04658bba4c8c30991df34/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org