You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by jkff <gi...@git.apache.org> on 2016/08/10 20:07:13 UTC

[GitHub] incubator-beam pull request #812: Rewrites DoFnReflector to go via DoFnSigna...

GitHub user jkff opened a pull request:

    https://github.com/apache/incubator-beam/pull/812

    Rewrites DoFnReflector to go via DoFnSignature

    DoFnSignature encapsulates type information about a DoFn,
    in particular which arguments/features its methods
    actually use.
    
    Before this commit, DoFnReflector would parse/verify/generate
    code in one go; after this commit, these stages are separated:
    DoFnSignature encapsulates all information needed to generate
    the code.
    
    Additionally, removes the unnecessary genericity in the
    implementation of DoFnReflector's code generation for the
    very different methods processElement and start/finishBundle.
    The code is simpler if decomposed into utility functions,
    rather than attempting a uniform representation for different
    methods.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jkff/incubator-beam do-fn-reflector

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/812.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #812
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-beam pull request #812: Rewrites DoFnReflector to go via DoFnSigna...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-beam/pull/812


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---