You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "cygnusdark (via GitHub)" <gi...@apache.org> on 2023/06/20 09:27:19 UTC

[GitHub] [doris-flink-connector] cygnusdark opened a new pull request, #150: Fix issue 149 by appointing a unique uid to each sink operator.

cygnusdark opened a new pull request, #150:
URL: https://github.com/apache/doris-flink-connector/pull/150

   # Proposed changes
   
   Issue Number: close #149 
   
   ## Problem Summary:
   
   Fix issue 149 by appointing a unique uid to each sink operator.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: No
   2. Has unit tests been added: No
   3. Has document been added or modified: No
   4. Does it need to update dependencies: No
   5. Are there any changes that cannot be rolled back: No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris-flink-connector] JNSimba merged pull request #150: Fix issue 149 by appointing a unique uid to each sink operator.

Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba merged PR #150:
URL: https://github.com/apache/doris-flink-connector/pull/150


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris-flink-connector] JNSimba commented on pull request #150: Fix issue 149 by appointing a unique uid to each sink operator.

Posted by "JNSimba (via GitHub)" <gi...@apache.org>.
JNSimba commented on PR #150:
URL: https://github.com/apache/doris-flink-connector/pull/150#issuecomment-1607135896

   Thanks for your contribution, good job
   By the way, when adding a new table, need to specify `--allowNonRestoredState`. 
   Can this PR solve this problem?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris-flink-connector] cygnusdark commented on pull request #150: Fix issue 149 by appointing a unique uid to each sink operator.

Posted by "cygnusdark (via GitHub)" <gi...@apache.org>.
cygnusdark commented on PR #150:
URL: https://github.com/apache/doris-flink-connector/pull/150#issuecomment-1608675166

   Yes. When adding a new table, if the previous sink operators had unique uid, `-allowNonRestoredState` argument is no need any more. 
   If `-allowNonRestoredState` used, the exact-once semantics will be broken, so I think this PR gives a better way to support adding new tables. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris-flink-connector] DongLiang-0 commented on pull request #150: Fix issue 149 by appointing a unique uid to each sink operator.

Posted by "DongLiang-0 (via GitHub)" <gi...@apache.org>.
DongLiang-0 commented on PR #150:
URL: https://github.com/apache/doris-flink-connector/pull/150#issuecomment-1608856800

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org