You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/04/09 10:01:12 UTC
[jira] [Commented] (THRIFT-3088) TThreadPoolServer with Sasl auth
may leak CLOSE_WAIT socket
[ https://issues.apache.org/jira/browse/THRIFT-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486930#comment-14486930 ]
ASF GitHub Bot commented on THRIFT-3088:
----------------------------------------
GitHub user punwinger opened a pull request:
https://github.com/apache/thrift/pull/432
[THRIFT-3088] TThreadPoolServer with Sasl auth may leak CLOSE_WAIT socket
Start TThreadPoolServer to server with TSaslServerTransport.Factory as transportFactory. While using nc to test the specified port whether reachable, it will leak CLOSE_WAIT socket.That's because nc will close socket at once while successful connect TThreadPoolServer, but the server still try using sasl protocol to build an inputTransport which of course failed at once. However inputTransport is null which makes it can't close socket properly which lead to CLOSE_WAIT socket.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/punwinger/thrift THRIFT-3088
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/432.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #432
----
commit c6067aabe8d1c209020633bb20a3d3144559a917
Author: Winger Pun <pu...@gmail.com>
Date: 2015-04-09T07:56:54Z
THRIFT-3088 TThreadPoolServer with Sasl auth may leak CLOSE_WAIT socket
TThreadPoolServer with Sasl auth may leak CLOSE_WAIT socket
----
> TThreadPoolServer with Sasl auth may leak CLOSE_WAIT socket
> -----------------------------------------------------------
>
> Key: THRIFT-3088
> URL: https://issues.apache.org/jira/browse/THRIFT-3088
> Project: Thrift
> Issue Type: Bug
> Components: Java - Library
> Affects Versions: 0.9
> Reporter: punwinger
>
> Start TThreadPoolServer to server with TSaslServerTransport.Factory as transportFactory. While using nc to test the specified port whether reachable, it will leak CLOSE_WAIT socket.That's because nc will close socket at once while successful connect TThreadPoolServer, but the server still try using sasl protocol to build an inputTransport which of course failed at once. However inputTransport is null which makes it can't close socket properly which lead to CLOSE_WAIT socket.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)