You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2013/10/08 03:23:41 UTC

[jira] [Commented] (ZOOKEEPER-1258) Move MultiResponse creation out of FinalRequestProcessor

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788803#comment-13788803 ] 

Hadoop QA commented on ZOOKEEPER-1258:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12501076/ZOOKEEPER-1258.patch
  against trunk revision 1530110.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1651//console

This message is automatically generated.

> Move MultiResponse creation out of FinalRequestProcessor
> --------------------------------------------------------
>
>                 Key: ZOOKEEPER-1258
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1258
>             Project: ZooKeeper
>          Issue Type: Sub-task
>            Reporter: Thomas Koch
>            Assignee: Thomas Koch
>         Attachments: ZOOKEEPER-1258.patch
>
>
> There is a longish code block in the switch case of the FinalRequestProcessor iterating over rc.multiResult and building a MultiResponse. Moved the code where it belongs, to MultiResponse and OpResult.



--
This message was sent by Atlassian JIRA
(v6.1#6144)