[jira] [Commented] (HADOOP-11229) JobStoryProducer is not closed upon return from Gridmix#setupDistCacheEmulation()

["Ted Yu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-11229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14193322#comment-14193322 ] 

Ted Yu commented on HADOOP-11229:
---------------------------------

Better enclose the call to close() in a try / finally around the following code:
{code}
      exitCode = distCacheEmulator.setupGenerateDistCacheData(jsp);
      if (exitCode == 0) {
        // If there are files to be generated, run a MapReduce job to generate
        // these distributed cache files of all the simulated jobs of this trace.
        writeDistCacheData(conf);
{code}

> JobStoryProducer is not closed upon return from Gridmix#setupDistCacheEmulation()
> ---------------------------------------------------------------------------------
>
>                 Key: HADOOP-11229
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11229
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: skrho
>            Priority: Minor
>         Attachments: HADOOP-11229_001.patch
>
>
> Here is related code:
> {code}
>       JobStoryProducer jsp = createJobStoryProducer(traceIn, conf);
>       exitCode = distCacheEmulator.setupGenerateDistCacheData(jsp);
> {code}
> jsp should be closed upon return from setupDistCacheEmulation().



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)