Re: Review Request 58825: SENTRY-1695: Waiting for HMS notifications from Thrift should be interruptible

[Sergio Pena <se...@cloudera.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58825/#review173473
-----------------------------------------------------------


Fix it, then Ship it!




The patch looks good Sasha. Just the minor comment I got confused for a little bit.


sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestCounterWait.java
Line 53 (original), 53 (patched)
<https://reviews.apache.org/r/58825/#comment246469>

    This //blocks comment might be confusing on this line. Should we move it next to the waitFor() ?


- Sergio Pena


On April 27, 2017, 11:33 p.m., Alexander Kolbasov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58825/
> -----------------------------------------------------------
> 
> (Updated April 27, 2017, 11:33 p.m.)
> 
> 
> Review request for sentry, Hao Hao, kalyan kumar kalvagadda, Na Li, Sergio Pena, and Vamsee Yarlagadda.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> SENTRY-1695: Waiting for HMS notifications from Thrift should be interruptible
> 
> 
> Diffs
> -----
> 
>   sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 456dabc234031c00455a564aa2bd6ea87690ceb1 
>   sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/CounterWait.java f593bffc827863955aa2591b3e387b2c7884242b 
>   sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestCounterWait.java a70017857b5e48071a9653a211da0fa6d9c51c1e 
> 
> 
> Diff: https://reviews.apache.org/r/58825/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Kolbasov
> 
>