You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/09/13 01:05:25 UTC
[GitHub] [incubator-nuttx] SPRESENSE opened a new pull request #4526: Rearch video
SPRESENSE opened a new pull request #4526:
URL: https://github.com/apache/incubator-nuttx/pull/4526
## Summary
Rearchtect video driver.
- Define two video I/F(struct imgsensor_ops_s and struct imgdata_ops_s),
and support them.
- Move isx012 driver to general driver directory
- Replace error output macro to verr
- Refactor camera initialization
- Update defconfig of camera example
## Impact
video, isx012 on Spresense board
## Testing
Tested by spresense:example_camera with https://github.com/apache/incubator-nuttx-apps/pull/851
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea merged pull request #4526: Rearch video
Posted by GitBox <gi...@apache.org>.
jerpelea merged pull request #4526:
URL: https://github.com/apache/incubator-nuttx/pull/4526
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #4526: Rearch video
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #4526:
URL: https://github.com/apache/incubator-nuttx/pull/4526#issuecomment-918823284
@SPRESENSE drivers/video/isx012.c can not contain board definitions
#include <arch/chip/cxd56_cisif.h>
please fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #4526: Rearch video
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #4526:
URL: https://github.com/apache/incubator-nuttx/pull/4526#issuecomment-918931030
@SPRESENSE please fix https://github.com/apache/incubator-nuttx/pull/4526/commits/f7cfbc11d1fcf0f40d0f4bccb9096b1dcc2a7a48
so that we have a clean build at every commit and then forcepush
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #4526: Rearch video
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #4526:
URL: https://github.com/apache/incubator-nuttx/pull/4526#discussion_r707409027
##########
File path: drivers/video/isx012.c
##########
@@ -34,12 +34,12 @@
#include <nuttx/fs/fs.h>
#include <nuttx/i2c/i2c_master.h>
#include <arch/board/board.h>
-#include <arch/chip/cisif.h>
+#include <arch/chip/cxd56_cisif.h>
Review comment:
it's specific to cxd56
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] SPRESENSE commented on pull request #4526: Rearch video
Posted by GitBox <gi...@apache.org>.
SPRESENSE commented on pull request #4526:
URL: https://github.com/apache/incubator-nuttx/pull/4526#issuecomment-918778702
> @SPRESENSE /github/workspace/sources/nuttx/arch/arm/src/chip/cxd56_cisif.c:1080: undefined reference to `imgdata_register'
Fixed a compile error by mpy/defconfig.
There are still build errors, but these will be fixed by the PR https://github.com/apache/incubator-nuttx-apps/pull/851.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] SPRESENSE commented on pull request #4526: Rearch video
Posted by GitBox <gi...@apache.org>.
SPRESENSE commented on pull request #4526:
URL: https://github.com/apache/incubator-nuttx/pull/4526#issuecomment-918913846
@jerpelea
In the final code (not in the middle of commit), `drivers/video/isx012.c` does not include `cxd56` and does not depend on `cxd56`. Please check it. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #4526: Rearch video
Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #4526:
URL: https://github.com/apache/incubator-nuttx/pull/4526#issuecomment-917868935
@SPRESENSE /github/workspace/sources/nuttx/arch/arm/src/chip/cxd56_cisif.c:1080: undefined reference to `imgdata_register'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea edited a comment on pull request #4526: Rearch video
Posted by GitBox <gi...@apache.org>.
jerpelea edited a comment on pull request #4526:
URL: https://github.com/apache/incubator-nuttx/pull/4526#issuecomment-918931030
@SPRESENSE please fix https://github.com/apache/incubator-nuttx/pull/4526/commits/f7cfbc11d1fcf0f40d0f4bccb9096b1dcc2a7a48
so that we have a clean build at every commit and then forcepush
NOTE
I saw that you fixed it in the next patch but the fix should not be necessary if it is fixed from the begining
https://github.com/apache/incubator-nuttx/pull/4526/commits/f06b5ef00f9e93caaf04144567e6a390f60b2777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea edited a comment on pull request #4526: Rearch video
Posted by GitBox <gi...@apache.org>.
jerpelea edited a comment on pull request #4526:
URL: https://github.com/apache/incubator-nuttx/pull/4526#issuecomment-918931030
@SPRESENSE please fix https://github.com/apache/incubator-nuttx/pull/4526/commits/f7cfbc11d1fcf0f40d0f4bccb9096b1dcc2a7a48
so that we have a clean build at every commit and then forcepush
A best practice is that each commit should compile standalone
NOTE
I saw that you fixed it in the next patch but the fix should not be necessary if it is fixed from the begining
https://github.com/apache/incubator-nuttx/pull/4526/commits/f06b5ef00f9e93caaf04144567e6a390f60b2777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org