You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Sascha Schumann <sa...@schumann.cx> on 2000/06/12 09:12:07 UTC

Re: cvs commit: apache-2.0/src/modules/standard mod_cern_meta.c mod_cgi.c

On 12 Jun 2000 rbb@locus.apache.org wrote:

> rbb         00/06/11 21:17:47
> 
>   Modified:    src      configure.in
>                src/modules/standard mod_cern_meta.c mod_cgi.c
>   Log:
>   Nothing in Apache should be calling stat anymore, so we can remove
>   the check for sys/stat.h and all references to the resulting macro.

    main/http_request.c and main/util.c still use lstat and stat.
    Also, ap_config.h still contains

    #ifdef HAVE_SYS_STAT_H
    include <sys/stat.h>
    #endif

    - Sascha


Re: cvs commit: apache-2.0/src/modules/standard mod_cern_meta.c mod_cgi.c

Posted by rb...@covalent.net.
> > >     main/http_request.c and main/util.c still use lstat and stat.
> > >     Also, ap_config.h still contains
> > 
> > I am fixing that now.  And neither of these used HAVE_SYS_STAT_H
> 
>     Yes, because they both, directly or indirectly, included
>     ap_config.h

It's not a real issue, because I am in the middle of fixing both of
these.  Expect this to be done in about an hour.  This was still compiling
cleanly on my machine last night.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Re: cvs commit: apache-2.0/src/modules/standard mod_cern_meta.c mod_cgi.c

Posted by Sascha Schumann <sa...@schumann.cx>.
On Mon, 12 Jun 2000 rbb@covalent.net wrote:

> 
> > >   Modified:    src      configure.in
> > >                src/modules/standard mod_cern_meta.c mod_cgi.c
> > >   Log:
> > >   Nothing in Apache should be calling stat anymore, so we can remove
> > >   the check for sys/stat.h and all references to the resulting macro.
> > 
> >     main/http_request.c and main/util.c still use lstat and stat.
> >     Also, ap_config.h still contains
> 
> I am fixing that now.  And neither of these used HAVE_SYS_STAT_H

    Yes, because they both, directly or indirectly, included
    ap_config.h

    - Sascha


Re: cvs commit: apache-2.0/src/modules/standard mod_cern_meta.c mod_cgi.c

Posted by rb...@covalent.net.
> >   Modified:    src      configure.in
> >                src/modules/standard mod_cern_meta.c mod_cgi.c
> >   Log:
> >   Nothing in Apache should be calling stat anymore, so we can remove
> >   the check for sys/stat.h and all references to the resulting macro.
> 
>     main/http_request.c and main/util.c still use lstat and stat.
>     Also, ap_config.h still contains

I am fixing that now.  And neither of these used HAVE_SYS_STAT_H

> 
>     #ifdef HAVE_SYS_STAT_H
>     include <sys/stat.h>
>     #endif

Hmmm...   That didn't show up in my grep.  It'll be removed in the next
commit.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------