You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2018/03/24 11:39:39 UTC
Re: Review Request 65705: Fixed CLI bootstrap script to work with long
workspace paths.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65705/
-----------------------------------------------------------
(Updated March 24, 2018, 11:39 a.m.)
Review request for mesos, Benjamin Bannier and Kevin Klues.
Changes
-------
Rebased.
Bugs: MESOS-8240
https://issues.apache.org/jira/browse/MESOS-8240
Repository: mesos
Description
-------
If the absolute path to the Python interpreter is long, it may exceed
the maximum length allowed for a shebang line (limit set to 128 on many
Linux distributions). When the shebang length limit is exceeded, pip
fails with the error: "bad interpreter: No such file or directory".
A work-around for this problem is to run the pip library module which is
what we do in this patch. This will also be done to use PyInstaller.
Diffs (updated)
-----
src/python/cli_new/bootstrap 9329a61a2a1f05286b4ff6e5fe68cd86ed48859a
Diff: https://reviews.apache.org/r/65705/diff/3/
Changes: https://reviews.apache.org/r/65705/diff/2-3/
Testing
-------
Tested on internal CI.
Thanks,
Armand Grillet
Re: Review Request 65705: Fixed CLI bootstrap script to work with long
workspace paths.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65705/
-----------------------------------------------------------
(Updated April 12, 2018, 12:39 p.m.)
Review request for mesos, Benjamin Bannier and Kevin Klues.
Changes
-------
Removed change regarding deactivation of existing virtualenv.
Bugs: MESOS-8240
https://issues.apache.org/jira/browse/MESOS-8240
Repository: mesos
Description
-------
If the absolute path to the Python interpreter is long, it may exceed
the maximum length allowed for a shebang line (limit set to 128 on many
Linux distributions). When the shebang length limit is exceeded, pip
fails with the error: "bad interpreter: No such file or directory".
A work-around for this problem is to run the pip library module which is
what we do in this patch. This will also be done to use PyInstaller.
Diffs (updated)
-----
src/python/cli_new/bootstrap 9329a61a2a1f05286b4ff6e5fe68cd86ed48859a
Diff: https://reviews.apache.org/r/65705/diff/5/
Changes: https://reviews.apache.org/r/65705/diff/4-5/
Testing
-------
Tested on internal CI.
Thanks,
Armand Grillet
Re: Review Request 65705: Fixed CLI bootstrap script to work with long
workspace paths.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65705/#review200996
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Klues
On March 24, 2018, 11:39 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65705/
> -----------------------------------------------------------
>
> (Updated March 24, 2018, 11:39 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Kevin Klues.
>
>
> Bugs: MESOS-8240
> https://issues.apache.org/jira/browse/MESOS-8240
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If the absolute path to the Python interpreter is long, it may exceed
> the maximum length allowed for a shebang line (limit set to 128 on many
> Linux distributions). When the shebang length limit is exceeded, pip
> fails with the error: "bad interpreter: No such file or directory".
>
> A work-around for this problem is to run the pip library module which is
> what we do in this patch. This will also be done to use PyInstaller.
>
>
> Diffs
> -----
>
> src/python/cli_new/bootstrap 9329a61a2a1f05286b4ff6e5fe68cd86ed48859a
>
>
> Diff: https://reviews.apache.org/r/65705/diff/4/
>
>
> Testing
> -------
>
> Tested on internal CI.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 65705: Fixed CLI bootstrap script to work with long
workspace paths.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65705/#review200994
-----------------------------------------------------------
src/python/cli_new/bootstrap
Line 27 (original), 27 (patched)
<https://reviews.apache.org/r/65705/#comment281926>
I see why this is a good change, but in the future, this should be done in a seperate commit.
- Kevin Klues
On March 24, 2018, 11:39 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65705/
> -----------------------------------------------------------
>
> (Updated March 24, 2018, 11:39 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Kevin Klues.
>
>
> Bugs: MESOS-8240
> https://issues.apache.org/jira/browse/MESOS-8240
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If the absolute path to the Python interpreter is long, it may exceed
> the maximum length allowed for a shebang line (limit set to 128 on many
> Linux distributions). When the shebang length limit is exceeded, pip
> fails with the error: "bad interpreter: No such file or directory".
>
> A work-around for this problem is to run the pip library module which is
> what we do in this patch. This will also be done to use PyInstaller.
>
>
> Diffs
> -----
>
> src/python/cli_new/bootstrap 9329a61a2a1f05286b4ff6e5fe68cd86ed48859a
>
>
> Diff: https://reviews.apache.org/r/65705/diff/4/
>
>
> Testing
> -------
>
> Tested on internal CI.
>
>
> Thanks,
>
> Armand Grillet
>
>