You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/12 18:22:30 UTC

[GitHub] [airflow] turbaszek commented on issue #12315: WebUI broken by custom XComBackend

turbaszek commented on issue #12315:
URL: https://github.com/apache/airflow/issues/12315#issuecomment-726254217


   The problem with rendering page can be simply fixed by replacing `!= None` with `is not none`. However, it seems that the `deserialize_value` method is called to render all XComValues. This is definitely not something that we would like to do if deserialisation can send request to external services.
   
   From what I understand the problem is much more complex because we call `deserialize_value` to recreate XCom ORM model:
   https://github.com/apache/airflow/blob/dd9ac785c4807aea4a1fb88a56d445d462c42b40/airflow/models/xcom.py#L59-L71
   
   What I would suggest is adding `deserialize_value_on_recreate` value that can be overwrite by users to adjust the behaviour (by default it should be simply `BaseXCom. deserialize_value`)
   
   WDYT @kaxil @mik-laj @XD-DENG 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org