You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Barna Zsombor Klara <zs...@cloudera.com> on 2017/04/18 12:19:15 UTC
Review Request 58501: HIVE-16469: Parquet timestamp table property is
not always taken into account
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58501/
-----------------------------------------------------------
Review request for hive and Sergio Pena.
Bugs: HIVE-16469
https://issues.apache.org/jira/browse/HIVE-16469
Repository: hive-git
Description
-------
HIVE-16469: Parquet timestamp table property is not always taken into account
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 917e565f28b2c9aaea18033ea3b6b20fa41fcd0a
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java 004bb2f60299a0635b8f9ca7649ead00b8e16d08
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapRedTask.java 1bd4db7805689ae1f91921ffbb5ff7da59f4bf60
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/MapredParquetInputFormat.java f4fadbb61bf45f62945700284c0b050f0984b696
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/ParquetRecordReaderBase.java 2954601ce5bb25905cdb29ca0ca4551c2ca12b95
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/ParquetTableUtils.java b339cc4347eea143dca2f6d98f9aa7777afdc427
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/timestamp/NanoTimeUtils.java dbd6fb3d0bc8c753abf86e99b52377617f248b5a
ql/src/test/queries/clientnegative/parquet_int96_alter_invalid_timezone.q PRE-CREATION
ql/src/test/queries/clientnegative/parquet_int96_create_invalid_timezone.q PRE-CREATION
ql/src/test/queries/clientpositive/parquet_int96_timestamp.q 6eadd1b0a3313cbba7a798890b802baae302749e
ql/src/test/results/clientnegative/parquet_int96_alter_invalid_timezone.q.out PRE-CREATION
ql/src/test/results/clientnegative/parquet_int96_create_invalid_timezone.q.out PRE-CREATION
ql/src/test/results/clientpositive/parquet_int96_timestamp.q.out b9a3664458a83f1856e4bc59eba5d56665df61cc
ql/src/test/results/clientpositive/spark/parquet_int96_timestamp.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/58501/diff/1/
Testing
-------
Added qtests for the following cases:
- order by clause
- selfjoin
- calling UDFs with the timestamp values
- where clause with a constant cast as timestamp
- test for HoS
Tested manually but no qtests:
- join between 3 tables all parquet but with different/no timezone property
- subselect in from/where clauses
- exists / union / no exists
Thanks,
Barna Zsombor Klara