You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/01/29 07:05:17 UTC
[GitHub] [incubator-nuttx] yamt opened a new pull request #179: macOS
support for sim
yamt opened a new pull request #179: macOS support for sim
URL: https://github.com/apache/incubator-nuttx/pull/179
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #179: macOS support for sim
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #179: macOS support for sim
URL: https://github.com/apache/incubator-nuttx/pull/179#discussion_r372229794
##########
File path: boards/sim/sim/sim/configs/cxxtest/Make.defs
##########
@@ -36,7 +36,7 @@
include ${TOPDIR}/.config
include ${TOPDIR}/tools/Config.mk
-HOSTOS = ${shell uname -o 2>/dev/null || echo "Other"}
+HOSTOS = ${shell uname -o 2>/dev/null || uname -s 2>/dev/null || echo "Other"}
Review comment:
should we fix the same issue in:
tools/define.sh
tools/incdir.sh
boards/arm/str71x/olimex-strp711/scripts/oocd.sh
arch/x86/src/Makefile
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #179: macOS support for sim
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #179: macOS support for sim
URL: https://github.com/apache/incubator-nuttx/pull/179#discussion_r372517931
##########
File path: arch/sim/src/sim/up_initialstate.c
##########
@@ -67,6 +67,6 @@
void up_initial_state(struct tcb_s *tcb)
{
memset(&tcb->xcp, 0, sizeof(struct xcptcontext));
Review comment:
Like the below dummy field:
struct xcptcontext
{
void *sigdeliver; /* Actual type is sig_deliver_t */
xcpt_reg_t dummy;
xcpt_reg_t regs[XCPTCONTEXT_REGS];
};
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #179:
macOS support for sim
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #179: macOS support for sim
URL: https://github.com/apache/incubator-nuttx/pull/179#discussion_r372485138
##########
File path: arch/sim/src/sim/up_initialstate.c
##########
@@ -67,6 +67,6 @@
void up_initial_state(struct tcb_s *tcb)
{
memset(&tcb->xcp, 0, sizeof(struct xcptcontext));
Review comment:
i don't understand your suggestion. can you explain?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #179: macOS support for sim
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #179: macOS support for sim
URL: https://github.com/apache/incubator-nuttx/pull/179#discussion_r372228836
##########
File path: tools/sethost.sh
##########
@@ -244,9 +244,9 @@ echo " Refreshing..."
cd $nuttx || { echo "ERROR: failed to cd to $nuttx"; exit 1; }
make clean_context 1>/dev/null 2>&1
if [ "X${debug}" = "Xy" ]; then
- make olddefconfig V=1
+ make olddefconfig V=1 || { echo "ERROR: failed to refresh"; exit 1; }
else
- make olddefconfig 1>/dev/null 2>&1
+ make olddefconfig 1>/dev/null || { echo "ERROR: failed to refresh"; exit 1; }
Review comment:
need keep 2>&1?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #179:
macOS support for sim
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #179: macOS support for sim
URL: https://github.com/apache/incubator-nuttx/pull/179#discussion_r372486705
##########
File path: arch/sim/src/Makefile
##########
@@ -195,8 +195,15 @@ endif
# Override in Make.defs if linker is not 'ld'
-LDSTARTGROUP ?= --start-group
-LDENDGROUP ?= --end-group
+ifeq ($(HOSTOS),Darwin)
+ LDSTARTGROUP ?=
+ LDENDGROUP ?=
+ LDUNEXPORTSYMBOLS ?= -unexported_symbols_list $(HOSTOS)-names.dat
Review comment:
do gnu ld have the option? my copy of its documentation doesn't have it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #179: macOS support for sim
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #179: macOS support for sim
URL: https://github.com/apache/incubator-nuttx/pull/179#discussion_r372237842
##########
File path: arch/sim/src/Makefile
##########
@@ -195,8 +195,15 @@ endif
# Override in Make.defs if linker is not 'ld'
-LDSTARTGROUP ?= --start-group
-LDENDGROUP ?= --end-group
+ifeq ($(HOSTOS),Darwin)
+ LDSTARTGROUP ?=
+ LDENDGROUP ?=
+ LDUNEXPORTSYMBOLS ?= -unexported_symbols_list $(HOSTOS)-names.dat
Review comment:
If so, why we don't update other platform to use -unexported_symbols_list? to simplify the logic in Makefile.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #179: macOS support for sim
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #179: macOS support for sim
URL: https://github.com/apache/incubator-nuttx/pull/179#discussion_r372239459
##########
File path: binfmt/binfmt_globals.c
##########
@@ -56,7 +56,7 @@
* protection to simply disable pre-emption when accessing this list.
*/
-FAR struct binfmt_s *g_binfmts;
+FAR struct binfmt_s *g_binfmts = NULL;
Review comment:
should we use -fno-common option instead? There are many place which don't initialize global variables explicitly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #179: macOS support for sim
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #179: macOS support for sim
URL: https://github.com/apache/incubator-nuttx/pull/179#discussion_r372511456
##########
File path: binfmt/binfmt_globals.c
##########
@@ -56,7 +56,7 @@
* protection to simply disable pre-emption when accessing this list.
*/
-FAR struct binfmt_s *g_binfmts;
+FAR struct binfmt_s *g_binfmts = NULL;
Review comment:
There are many places which don't set the global variable to NULL, the same error will report again and again if we turn more option in defconfig. The right fix is to add -fno-common.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #179: macOS support for sim
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #179: macOS support for sim
URL: https://github.com/apache/incubator-nuttx/pull/179#discussion_r372533638
##########
File path: arch/sim/src/Makefile
##########
@@ -195,8 +195,15 @@ endif
# Override in Make.defs if linker is not 'ld'
-LDSTARTGROUP ?= --start-group
-LDENDGROUP ?= --end-group
+ifeq ($(HOSTOS),Darwin)
+ LDSTARTGROUP ?=
+ LDENDGROUP ?=
+ LDUNEXPORTSYMBOLS ?= -unexported_symbols_list $(HOSTOS)-names.dat
Review comment:
Emm, unexported_symbols_list doesn't support on Linux, but after searching we can install binutils and use gobjcopy?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #179:
macOS support for sim
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #179: macOS support for sim
URL: https://github.com/apache/incubator-nuttx/pull/179#discussion_r372484349
##########
File path: boards/sim/sim/sim/configs/cxxtest/Make.defs
##########
@@ -36,7 +36,7 @@
include ${TOPDIR}/.config
include ${TOPDIR}/tools/Config.mk
-HOSTOS = ${shell uname -o 2>/dev/null || echo "Other"}
+HOSTOS = ${shell uname -o 2>/dev/null || uname -s 2>/dev/null || echo "Other"}
Review comment:
i guess it doesn't actually matter as they seem just checking if cygwin or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #179:
macOS support for sim
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #179: macOS support for sim
URL: https://github.com/apache/incubator-nuttx/pull/179#discussion_r372531848
##########
File path: arch/sim/src/sim/up_initialstate.c
##########
@@ -67,6 +67,6 @@
void up_initial_state(struct tcb_s *tcb)
{
memset(&tcb->xcp, 0, sizeof(struct xcptcontext));
Review comment:
this change is about the actual stack alignment. that is, the value of RSP register.
not about the context structure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #179:
macOS support for sim
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #179: macOS support for sim
URL: https://github.com/apache/incubator-nuttx/pull/179#discussion_r372488773
##########
File path: binfmt/binfmt_globals.c
##########
@@ -56,7 +56,7 @@
* protection to simply disable pre-emption when accessing this list.
*/
-FAR struct binfmt_s *g_binfmts;
+FAR struct binfmt_s *g_binfmts = NULL;
Review comment:
i think it works. do you prefer it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #179: macOS support for
sim
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #179: macOS support for sim
URL: https://github.com/apache/incubator-nuttx/pull/179#issuecomment-579624514
apps part of this: https://github.com/apache/incubator-nuttx-apps/pull/35
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #179: macOS support for sim
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #179: macOS support for sim
URL: https://github.com/apache/incubator-nuttx/pull/179#discussion_r372233861
##########
File path: arch/sim/src/sim/up_initialstate.c
##########
@@ -67,6 +67,6 @@
void up_initial_state(struct tcb_s *tcb)
{
memset(&tcb->xcp, 0, sizeof(struct xcptcontext));
Review comment:
How about we add a dummy field in xcptcontext instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #179:
macOS support for sim
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #179: macOS support for sim
URL: https://github.com/apache/incubator-nuttx/pull/179#discussion_r372481926
##########
File path: tools/sethost.sh
##########
@@ -244,9 +244,9 @@ echo " Refreshing..."
cd $nuttx || { echo "ERROR: failed to cd to $nuttx"; exit 1; }
make clean_context 1>/dev/null 2>&1
if [ "X${debug}" = "Xy" ]; then
- make olddefconfig V=1
+ make olddefconfig V=1 || { echo "ERROR: failed to refresh"; exit 1; }
else
- make olddefconfig 1>/dev/null 2>&1
+ make olddefconfig 1>/dev/null || { echo "ERROR: failed to refresh"; exit 1; }
Review comment:
it's intentional to expose the errors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #179: macOS support for sim
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #179: macOS support for sim
URL: https://github.com/apache/incubator-nuttx/pull/179#discussion_r372533638
##########
File path: arch/sim/src/Makefile
##########
@@ -195,8 +195,15 @@ endif
# Override in Make.defs if linker is not 'ld'
-LDSTARTGROUP ?= --start-group
-LDENDGROUP ?= --end-group
+ifeq ($(HOSTOS),Darwin)
+ LDSTARTGROUP ?=
+ LDENDGROUP ?=
+ LDUNEXPORTSYMBOLS ?= -unexported_symbols_list $(HOSTOS)-names.dat
Review comment:
Emm, unexported_symbols_list doesn't support on Linux, but after searching we can install binutils and use gobjcopy? even for ld so we don't modify Makefile at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #179:
macOS support for sim
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #179: macOS support for sim
URL: https://github.com/apache/incubator-nuttx/pull/179#discussion_r372494257
##########
File path: arch/sim/src/sim/up_setjmp32.S
##########
@@ -46,8 +46,12 @@
#ifdef __CYGWIN__
# define SYMBOL(s) _##s
#else
+#ifdef __ELF__
Review comment:
https://github.com/apache/incubator-nuttx/pull/181
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #179: macOS support for sim
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #179: macOS support for sim
URL: https://github.com/apache/incubator-nuttx/pull/179#discussion_r372521264
##########
File path: boards/sim/sim/sim/configs/cxxtest/Make.defs
##########
@@ -36,7 +36,7 @@
include ${TOPDIR}/.config
include ${TOPDIR}/tools/Config.mk
-HOSTOS = ${shell uname -o 2>/dev/null || echo "Other"}
+HOSTOS = ${shell uname -o 2>/dev/null || uname -s 2>/dev/null || echo "Other"}
Review comment:
Yes, you are right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #179:
macOS support for sim
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #179: macOS support for sim
URL: https://github.com/apache/incubator-nuttx/pull/179#discussion_r372532370
##########
File path: binfmt/binfmt_globals.c
##########
@@ -56,7 +56,7 @@
* protection to simply disable pre-emption when accessing this list.
*/
-FAR struct binfmt_s *g_binfmts;
+FAR struct binfmt_s *g_binfmts = NULL;
Review comment:
ok, let me try the -fno-common approach later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #179:
macOS support for sim
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #179: macOS support for sim
URL: https://github.com/apache/incubator-nuttx/pull/179#discussion_r372489774
##########
File path: arch/sim/src/sim/up_setjmp32.S
##########
@@ -46,8 +46,12 @@
#ifdef __CYGWIN__
# define SYMBOL(s) _##s
#else
+#ifdef __ELF__
Review comment:
oops, you are right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #179:
macOS support for sim
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #179: macOS support for sim
URL: https://github.com/apache/incubator-nuttx/pull/179#discussion_r372913101
##########
File path: arch/sim/src/sim/up_initialstate.c
##########
@@ -67,6 +67,6 @@
void up_initial_state(struct tcb_s *tcb)
{
memset(&tcb->xcp, 0, sizeof(struct xcptcontext));
Review comment:
the convention is, align _before_ a function call.
that is, from POV of the function being called, it will be aligned after pushing RBP.
note that up_longjmp jumps into the function directly. (without pushing the return address)
RSP at that point should not be aligned.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #179:
macOS support for sim
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #179: macOS support for sim
URL: https://github.com/apache/incubator-nuttx/pull/179#discussion_r372548116
##########
File path: arch/sim/src/Makefile
##########
@@ -195,8 +195,15 @@ endif
# Override in Make.defs if linker is not 'ld'
-LDSTARTGROUP ?= --start-group
-LDENDGROUP ?= --end-group
+ifeq ($(HOSTOS),Darwin)
+ LDSTARTGROUP ?=
+ LDENDGROUP ?=
+ LDUNEXPORTSYMBOLS ?= -unexported_symbols_list $(HOSTOS)-names.dat
Review comment:
as i mentioned in the commit logs, gnu binutils didn't actually work for me.
objcopy runs without errors, producing a corrupted object.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #179: macOS support for sim
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #179: macOS support for sim
URL: https://github.com/apache/incubator-nuttx/pull/179#discussion_r372768107
##########
File path: arch/sim/src/Makefile
##########
@@ -195,8 +195,15 @@ endif
# Override in Make.defs if linker is not 'ld'
-LDSTARTGROUP ?= --start-group
-LDENDGROUP ?= --end-group
+ifeq ($(HOSTOS),Darwin)
+ LDSTARTGROUP ?=
+ LDENDGROUP ?=
+ LDUNEXPORTSYMBOLS ?= -unexported_symbols_list $(HOSTOS)-names.dat
Review comment:
Ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #179: macOS support for sim
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #179: macOS support for sim
URL: https://github.com/apache/incubator-nuttx/pull/179#discussion_r372519998
##########
File path: tools/sethost.sh
##########
@@ -244,9 +244,9 @@ echo " Refreshing..."
cd $nuttx || { echo "ERROR: failed to cd to $nuttx"; exit 1; }
make clean_context 1>/dev/null 2>&1
if [ "X${debug}" = "Xy" ]; then
- make olddefconfig V=1
+ make olddefconfig V=1 || { echo "ERROR: failed to refresh"; exit 1; }
else
- make olddefconfig 1>/dev/null 2>&1
+ make olddefconfig 1>/dev/null || { echo "ERROR: failed to refresh"; exit 1; }
Review comment:
Ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #179: macOS support for sim
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #179: macOS support for sim
URL: https://github.com/apache/incubator-nuttx/pull/179#discussion_r372242597
##########
File path: arch/sim/src/sim/up_setjmp32.S
##########
@@ -46,8 +46,12 @@
#ifdef __CYGWIN__
# define SYMBOL(s) _##s
#else
+#ifdef __ELF__
Review comment:
The logic is wrong, should it be #ifndef?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] jerpelea merged pull request #179: macOS support
for sim
Posted by GitBox <gi...@apache.org>.
jerpelea merged pull request #179: macOS support for sim
URL: https://github.com/apache/incubator-nuttx/pull/179
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #179: macOS support for sim
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #179: macOS support for sim
URL: https://github.com/apache/incubator-nuttx/pull/179#discussion_r372773380
##########
File path: arch/sim/src/sim/up_initialstate.c
##########
@@ -67,6 +67,6 @@
void up_initial_state(struct tcb_s *tcb)
{
memset(&tcb->xcp, 0, sizeof(struct xcptcontext));
Review comment:
My previous comment is wrong, but all places(up_use_stack/up_stack_frame) which modify adj_stack_ptr already align this pointer to 16B boundary, the extra subtraction just make the situation even worse, I can't understand why this change fix your problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services