You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/27 18:49:45 UTC
[GitHub] [beam] amaliujia opened a new pull request #11252: [BEAM-9557] Fix
timer window boundary checking
amaliujia opened a new pull request #11252: [BEAM-9557] Fix timer window boundary checking
URL: https://github.com/apache/beam/pull/11252
R @aaltay @reuvenlax @steveniemitz
Sorry for sending Reuven's change #11226 in this PR. I am just trying to help to solve this release blocker by fixing: https://github.com/apache/beam/pull/11226#issuecomment-604729044. However I didn't find a way to directly append the fix to #11226
Please let me know if you still prefer to use #11226, we could figure a way out.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] amaliujia commented on issue #11252: [BEAM-9557] Fix timer
window boundary checking
Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11252: [BEAM-9557] Fix timer window boundary checking
URL: https://github.com/apache/beam/pull/11252#issuecomment-605522234
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] amaliujia commented on issue #11252: [BEAM-9557] Fix timer
window boundary checking
Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11252: [BEAM-9557] Fix timer window boundary checking
URL: https://github.com/apache/beam/pull/11252#issuecomment-605522214
Run Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] amaliujia commented on issue #11252: [BEAM-9557] Fix timer
window boundary checking
Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11252: [BEAM-9557] Fix timer window boundary checking
URL: https://github.com/apache/beam/pull/11252#issuecomment-605283852
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] amaliujia merged pull request #11252: [BEAM-9557] Fix timer
window boundary checking
Posted by GitBox <gi...@apache.org>.
amaliujia merged pull request #11252: [BEAM-9557] Fix timer window boundary checking
URL: https://github.com/apache/beam/pull/11252
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] amaliujia commented on issue #11252: [BEAM-9557] Fix timer
window boundary checking
Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11252: [BEAM-9557] Fix timer window boundary checking
URL: https://github.com/apache/beam/pull/11252#issuecomment-605361234
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] amaliujia commented on issue #11252: [BEAM-9557] Fix timer
window boundary checking
Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11252: [BEAM-9557] Fix timer window boundary checking
URL: https://github.com/apache/beam/pull/11252#issuecomment-605392133
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] amaliujia commented on issue #11252: [BEAM-9557] Fix timer
window boundary checking
Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11252: [BEAM-9557] Fix timer window boundary checking
URL: https://github.com/apache/beam/pull/11252#issuecomment-605401221
Run Website PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] amaliujia commented on issue #11252: [BEAM-9557] Fix timer
window boundary checking
Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11252: [BEAM-9557] Fix timer window boundary checking
URL: https://github.com/apache/beam/pull/11252#issuecomment-605401396
Run CommunityMetrics PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] amaliujia commented on issue #11252: [BEAM-9557] Fix timer
window boundary checking
Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11252: [BEAM-9557] Fix timer window boundary checking
URL: https://github.com/apache/beam/pull/11252#issuecomment-605401420
Run PythonLint PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] amaliujia commented on issue #11252: [BEAM-9557] Fix timer
window boundary checking
Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11252: [BEAM-9557] Fix timer window boundary checking
URL: https://github.com/apache/beam/pull/11252#issuecomment-605401231
Run JavaPortabilityApi PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] amaliujia commented on issue #11252: [BEAM-9557] Fix timer
window boundary checking
Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11252: [BEAM-9557] Fix timer window boundary checking
URL: https://github.com/apache/beam/pull/11252#issuecomment-605401409
Run PythonFormatter PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] amaliujia commented on issue #11252: [BEAM-9557] Fix timer
window boundary checking
Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11252: [BEAM-9557] Fix timer window boundary checking
URL: https://github.com/apache/beam/pull/11252#issuecomment-605401312
Run Website_Stage_GCS PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] amaliujia commented on issue #11252: [BEAM-9557] Fix timer
window boundary checking
Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11252: [BEAM-9557] Fix timer window boundary checking
URL: https://github.com/apache/beam/pull/11252#issuecomment-605401405
Run Java_Examples_Dataflow PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] amaliujia commented on issue #11252: [BEAM-9557] Fix timer
window boundary checking
Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11252: [BEAM-9557] Fix timer window boundary checking
URL: https://github.com/apache/beam/pull/11252#issuecomment-605403432
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] amaliujia commented on issue #11252: [BEAM-9557] Fix timer
window boundary checking
Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11252: [BEAM-9557] Fix timer window boundary checking
URL: https://github.com/apache/beam/pull/11252#issuecomment-605401246
Run Go PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] amaliujia commented on issue #11252: [BEAM-9557] Fix timer
window boundary checking
Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11252: [BEAM-9557] Fix timer window boundary checking
URL: https://github.com/apache/beam/pull/11252#issuecomment-605401285
Run Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] amaliujia commented on issue #11252: [BEAM-9557] Fix timer
window boundary checking
Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11252: [BEAM-9557] Fix timer window boundary checking
URL: https://github.com/apache/beam/pull/11252#issuecomment-605317542
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] amaliujia commented on issue #11252: [BEAM-9557] Fix timer
window boundary checking
Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11252: [BEAM-9557] Fix timer window boundary checking
URL: https://github.com/apache/beam/pull/11252#issuecomment-605323570
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] amaliujia commented on issue #11252: [BEAM-9557] Fix timer
window boundary checking
Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11252: [BEAM-9557] Fix timer window boundary checking
URL: https://github.com/apache/beam/pull/11252#issuecomment-605401262
Run JavaBeamZetaSQL PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] amaliujia commented on issue #11252: [BEAM-9557] Fix timer
window boundary checking
Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11252: [BEAM-9557] Fix timer window boundary checking
URL: https://github.com/apache/beam/pull/11252#issuecomment-605400710
Run SQL PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] amaliujia commented on issue #11252: [BEAM-9557] Fix timer
window boundary checking
Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11252: [BEAM-9557] Fix timer window boundary checking
URL: https://github.com/apache/beam/pull/11252#issuecomment-605401784
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services