You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Bojan Smojver <bo...@rexursive.com> on 2012/01/30 08:08:52 UTC
Re: svn commit: r817809 - in /apr/apr/branches/1.4.x: CHANGES
include/apr_hash.h tables/apr_hash.c
On Tue, 2009-09-22 at 20:06 +0000, minfrin@apache.org wrote:
> URL: http://svn.apache.org/viewvc?rev=817809&view=rev
> Log:
> The implementation of expand_array() in tables/apr_hash.c allocates
> a new bucket array, without making any attempt to release the memory
> allocated for the previous bucket array. That wastes memory: if the
> hash table grows exponentially, this strategy wastes O(n) extra memory.
> Use a subpool instead.
> Submitted by: Neil Conway <nrc cs.berkeley.edu>
Somehow this commit never made it into trunk. It only exists in what is
now 1.5.x. Anyone knows why?
--
Bojan
Re: svn commit: r817809 - in /apr/apr/branches/1.4.x: CHANGES include/apr_hash.h tables/apr_hash.c
Posted by Philip Martin <ph...@codematters.co.uk>.
Bojan Smojver <bo...@rexursive.com> writes:
> On Mon, 2012-01-30 at 10:22 +0000, Philip Martin wrote:
>> It was reverted because it means the hash table data is not available
>> in pool cleanup handlers
>
> I guess it should then be reverted on the 1.5.x branch as well.
Yes, I believe so.
--
Philip
Re: svn commit: r817809 - in /apr/apr/branches/1.4.x: CHANGES
include/apr_hash.h tables/apr_hash.c
Posted by Bojan Smojver <bo...@rexursive.com>.
On Mon, 2012-01-30 at 10:22 +0000, Philip Martin wrote:
> It was reverted because it means the hash table data is not available
> in pool cleanup handlers
I guess it should then be reverted on the 1.5.x branch as well.
--
Bojan
Re: svn commit: r817809 - in /apr/apr/branches/1.4.x: CHANGES include/apr_hash.h tables/apr_hash.c
Posted by Philip Martin <ph...@codematters.co.uk>.
Bojan Smojver <bo...@rexursive.com> writes:
> On Tue, 2009-09-22 at 20:06 +0000, minfrin@apache.org wrote:
>> URL: http://svn.apache.org/viewvc?rev=817809&view=rev
>> Log:
>> The implementation of expand_array() in tables/apr_hash.c allocates
>> a new bucket array, without making any attempt to release the memory
>> allocated for the previous bucket array. That wastes memory: if the
>> hash table grows exponentially, this strategy wastes O(n) extra memory.
>> Use a subpool instead.
>> Submitted by: Neil Conway <nrc cs.berkeley.edu>
>
> Somehow this commit never made it into trunk. It only exists in what is
> now 1.5.x. Anyone knows why?
It was reverted because it means the hash table data is not available in
pool cleanup handlers:
http://mail-archives.apache.org/mod_mbox/apr-dev/201001.mbox/%3C004001ca8fab$c7089b10$5519d130$@qqmail.nl%3E
--
Philip