You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2018/11/11 11:49:06 UTC

[GitHub] spark pull request #22973: [SPARK-25972][PYTHON] Missed JSON options in stre...

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22973#discussion_r232484720
  
    --- Diff: python/pyspark/sql/streaming.py ---
    @@ -467,11 +468,18 @@ def json(self, path, schema=None, primitivesAsString=None, prefersDecimal=None,
             :param allowUnquotedControlChars: allows JSON Strings to contain unquoted control
                                               characters (ASCII characters with value less than 32,
                                               including tab and line feed characters) or not.
    +        :param encoding: allows to forcibly set one of standard basic or extended encoding for
    +                         the JSON files. For example UTF-16BE, UTF-32LE. If None is set,
    +                         the encoding of input JSON will be detected automatically
    +                         when the multiLine option is set to ``true``.
             :param lineSep: defines the line separator that should be used for parsing. If None is
                             set, it covers all ``\\r``, ``\\r\\n`` and ``\\n``.
             :param locale: sets a locale as language tag in IETF BCP 47 format. If None is set,
                            it uses the default value, ``en-US``. For instance, ``locale`` is used while
                            parsing dates and timestamps.
    +        :param dropFieldIfAllNull: whether to ignore column of all null values or empty
    +                                   array/struct during schema inference. If None is set, it
    +                                   uses the default value, ``false``.
    --- End diff --
    
    @MaxGekk, let's match its order (the doc and parameters).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org