[GitHub] [druid] suneet-s commented on a change in pull request #12211: Reduce RemoteTaskRunnerTest flakiness

[GitBox <gi...@apache.org>]

suneet-s commented on a change in pull request #12211:
URL: https://github.com/apache/druid/pull/12211#discussion_r795888841



##########
File path: indexing-service/src/main/java/org/apache/druid/indexing/overlord/RemoteTaskRunner.java
##########
@@ -223,6 +223,7 @@ public void start()
       return;
     }
     try {
+      log.info("Starting...");

Review comment:
       ```suggestion
         log.info("Starting RemoteTaskRunner...");
   ```

##########
File path: indexing-service/src/main/java/org/apache/druid/indexing/overlord/RemoteTaskRunner.java
##########
@@ -350,6 +351,7 @@ public void stop()
       return;
     }
     try {
+      log.info("Stopping...");

Review comment:
       I noticed the HttpRemoteTaskRunner and SegmentLoadDropHandler also just have logs that say `Starting...` and `Stopping...` To make the logs easier to follow, I think it's better to add some more identifying info to the logs.
   
   `WorkTaskManager` also has a debug log `Starting...`
   
   ```suggestion
         log.info("Stopping RemoteTaskRunner...");
   ```
   
   Would you mind fixing up these logs too if you're going to make another patch




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org