You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2022/08/29 09:18:05 UTC
[GitHub] [avro] clesaec opened a new pull request, #1842: Avro 3618 test binary decoder
clesaec opened a new pull request, #1842:
URL: https://github.com/apache/avro/pull/1842
[AVRO-3618](https://issues.apache.org/jira/browse/AVRO-3618) : update unit test testBinaryDecoder to test directBinaryDecoder before moving it in JUnit5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba commented on pull request #1842: Avro 3618 test binary decoder
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on PR #1842:
URL: https://github.com/apache/avro/pull/1842#issuecomment-1230246409
Hi @clesaec -- it looks like you have some old merge commits on your `master` branch (the first 13 commits from July 5 to the last commit). This probably isn't intentional; best practice is usually for local `master` to track`apache/master` exactly. You might want to reset it on your local machine!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] clesaec commented on pull request #1842: Avro 3618 test binary decoder
Posted by GitBox <gi...@apache.org>.
clesaec commented on PR #1842:
URL: https://github.com/apache/avro/pull/1842#issuecomment-1230333335
Hi Ryan,
Indeed, i rebased my master on apache master, then rebase my branch on it, but it seems to have no effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba commented on a diff in pull request #1842: Avro 3618 test binary decoder
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on code in PR #1842:
URL: https://github.com/apache/avro/pull/1842#discussion_r960967471
##########
lang/java/avro/src/test/java/org/apache/avro/io/TestBinaryDecoder.java:
##########
@@ -317,7 +320,7 @@ private void validateInputStreamSkips(InputStream test, InputStream check) throw
public void testBadIntEncoding() throws IOException {
byte[] badint = new byte[5];
Arrays.fill(badint, (byte) 0xff);
- Decoder bd = factory.binaryDecoder(badint, null);
+ Decoder bd = this.newDecoder(badint);
Review Comment:
To clarify the purpose of the JIRA: this test only checks that `binaryEncoder` correctly deals with badly encoded INTs, and it does it twice. One of those times, `directBinaryEncoder` should be called!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba merged pull request #1842: AVRO-3618: Test both directBinaryDecoder and binaryDecoder
Posted by GitBox <gi...@apache.org>.
RyanSkraba merged PR #1842:
URL: https://github.com/apache/avro/pull/1842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] clesaec commented on pull request #1842: AVRO-3618: Test both directBinaryDecoder and binaryDecoder
Posted by GitBox <gi...@apache.org>.
clesaec commented on PR #1842:
URL: https://github.com/apache/avro/pull/1842#issuecomment-1246324671
Behaviours aligned
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba commented on pull request #1842: AVRO-3618: Test both directBinaryDecoder and binaryDecoder
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on PR #1842:
URL: https://github.com/apache/avro/pull/1842#issuecomment-1247157453
Thanks so much for your patience!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] clesaec commented on a diff in pull request #1842: AVRO-3618: Test both directBinaryDecoder and binaryDecoder
Posted by GitBox <gi...@apache.org>.
clesaec commented on code in PR #1842:
URL: https://github.com/apache/avro/pull/1842#discussion_r961354244
##########
lang/java/avro/src/test/java/org/apache/avro/io/TestBinaryDecoder.java:
##########
@@ -317,7 +320,7 @@ private void validateInputStreamSkips(InputStream test, InputStream check) throw
public void testBadIntEncoding() throws IOException {
byte[] badint = new byte[5];
Arrays.fill(badint, (byte) 0xff);
- Decoder bd = factory.binaryDecoder(badint, null);
+ Decoder bd = this.newDecoder(badint);
Review Comment:
Change, all methods now test DirectBinaryDecoder, then BinaryDecoder. We can see that the behavior sometimes differs with the type of exceptions that are thrown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org