You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@oozie.apache.org by "Prakhar Sharma (Created) (JIRA)" <ji...@apache.org> on 2011/10/14 01:48:11 UTC
[jira] [Created] (OOZIE-581) Fix unit test failure in
TestStatusTransitService.java
Fix unit test failure in TestStatusTransitService.java
------------------------------------------------------
Key: OOZIE-581
URL: https://issues.apache.org/jira/browse/OOZIE-581
Project: Oozie
Issue Type: Bug
Reporter: Prakhar Sharma
Priority: Minor
Test case TestStatusTransitService::testCoordStatusTransitServiceKilledByUser1() fails due to race condition between status service and the check assertEquals(true, coordJob.isPending()). The kill action has already been completed by the time assertion is checked. Working on the fix.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-581) Fix unit test failure in
TestStatusTransitService.java
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127918#comment-13127918 ]
jiraposter@reviews.apache.org commented on OOZIE-581:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2386/
-----------------------------------------------------------
(Updated 2011-10-14 22:16:23.602791)
Review request for oozie, Mohammad Islam and Angelo K. Huang.
Changes
-------
Adding comment to rationalize the change. Reverting redundant wait added to two additional cases in the first diff.
Summary
-------
Test case TestStatusTransitService::testCoordStatusTransitServiceKilledByUser1() fails due to race condition between status service and the check assertEquals(true, coordJob.isPending()). The kill action has already been completed by the time assertion is checked.
This addresses bug OOZIE-581.
https://issues.apache.org/jira/browse/OOZIE-581
Diffs (updated)
-----
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 1181872
Diff: https://reviews.apache.org/r/2386/diff
Testing
-------
Thanks,
Prakhar
> Fix unit test failure in TestStatusTransitService.java
> ------------------------------------------------------
>
> Key: OOZIE-581
> URL: https://issues.apache.org/jira/browse/OOZIE-581
> Project: Oozie
> Issue Type: Bug
> Reporter: Prakhar Sharma
> Priority: Minor
>
> Test case TestStatusTransitService::testCoordStatusTransitServiceKilledByUser1() fails due to race condition between status service and the check assertEquals(true, coordJob.isPending()). The kill action has already been completed by the time assertion is checked. Working on the fix.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OOZIE-581) Fix unit test failure in
TestStatusTransitService.java
Posted by "Prakhar Sharma (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prakhar Sharma resolved OOZIE-581.
----------------------------------
Resolution: Fixed
Changes have been committed. Marking as fixed. thx --Prakhar
> Fix unit test failure in TestStatusTransitService.java
> ------------------------------------------------------
>
> Key: OOZIE-581
> URL: https://issues.apache.org/jira/browse/OOZIE-581
> Project: Oozie
> Issue Type: Bug
> Reporter: Prakhar Sharma
> Priority: Minor
>
> Test case TestStatusTransitService::testCoordStatusTransitServiceKilledByUser1() fails due to race condition between status service and the check assertEquals(true, coordJob.isPending()). The kill action has already been completed by the time assertion is checked. Working on the fix.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-581) Fix unit test failure in
TestStatusTransitService.java
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127161#comment-13127161 ]
jiraposter@reviews.apache.org commented on OOZIE-581:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2386/
-----------------------------------------------------------
Review request for oozie, Mohammad Islam and Angelo K. Huang.
Summary
-------
Test case TestStatusTransitService::testCoordStatusTransitServiceKilledByUser1() fails due to race condition between status service and the check assertEquals(true, coordJob.isPending()). The kill action has already been completed by the time assertion is checked.
This addresses bug OOZIE-581.
https://issues.apache.org/jira/browse/OOZIE-581
Diffs
-----
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 1181872
Diff: https://reviews.apache.org/r/2386/diff
Testing
-------
Thanks,
Prakhar
> Fix unit test failure in TestStatusTransitService.java
> ------------------------------------------------------
>
> Key: OOZIE-581
> URL: https://issues.apache.org/jira/browse/OOZIE-581
> Project: Oozie
> Issue Type: Bug
> Reporter: Prakhar Sharma
> Priority: Minor
>
> Test case TestStatusTransitService::testCoordStatusTransitServiceKilledByUser1() fails due to race condition between status service and the check assertEquals(true, coordJob.isPending()). The kill action has already been completed by the time assertion is checked. Working on the fix.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-581) Fix unit test failure in
TestStatusTransitService.java
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129264#comment-13129264 ]
jiraposter@reviews.apache.org commented on OOZIE-581:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2386/#review2631
-----------------------------------------------------------
Ship it!
+1
- Santhosh
On 2011-10-14 22:16:23, Prakhar Sharma wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2386/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-14 22:16:23)
bq.
bq.
bq. Review request for oozie, Mohammad Islam and Angelo K. Huang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Test case TestStatusTransitService::testCoordStatusTransitServiceKilledByUser1() fails due to race condition between status service and the check assertEquals(true, coordJob.isPending()). The kill action has already been completed by the time assertion is checked.
bq.
bq.
bq. This addresses bug OOZIE-581.
bq. https://issues.apache.org/jira/browse/OOZIE-581
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 1181872
bq.
bq. Diff: https://reviews.apache.org/r/2386/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Prakhar
bq.
bq.
> Fix unit test failure in TestStatusTransitService.java
> ------------------------------------------------------
>
> Key: OOZIE-581
> URL: https://issues.apache.org/jira/browse/OOZIE-581
> Project: Oozie
> Issue Type: Bug
> Reporter: Prakhar Sharma
> Priority: Minor
>
> Test case TestStatusTransitService::testCoordStatusTransitServiceKilledByUser1() fails due to race condition between status service and the check assertEquals(true, coordJob.isPending()). The kill action has already been completed by the time assertion is checked. Working on the fix.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-581) Fix unit test failure in
TestStatusTransitService.java
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129276#comment-13129276 ]
jiraposter@reviews.apache.org commented on OOZIE-581:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2386/#review2632
-----------------------------------------------------------
Committed. Please add release log next time.
Now you could close the review request and the JIRA.
- Mohammad
On 2011-10-14 22:16:23, Prakhar Sharma wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2386/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-14 22:16:23)
bq.
bq.
bq. Review request for oozie, Mohammad Islam and Angelo K. Huang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Test case TestStatusTransitService::testCoordStatusTransitServiceKilledByUser1() fails due to race condition between status service and the check assertEquals(true, coordJob.isPending()). The kill action has already been completed by the time assertion is checked.
bq.
bq.
bq. This addresses bug OOZIE-581.
bq. https://issues.apache.org/jira/browse/OOZIE-581
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 1181872
bq.
bq. Diff: https://reviews.apache.org/r/2386/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Prakhar
bq.
bq.
> Fix unit test failure in TestStatusTransitService.java
> ------------------------------------------------------
>
> Key: OOZIE-581
> URL: https://issues.apache.org/jira/browse/OOZIE-581
> Project: Oozie
> Issue Type: Bug
> Reporter: Prakhar Sharma
> Priority: Minor
>
> Test case TestStatusTransitService::testCoordStatusTransitServiceKilledByUser1() fails due to race condition between status service and the check assertEquals(true, coordJob.isPending()). The kill action has already been completed by the time assertion is checked. Working on the fix.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-581) Fix unit test failure in
TestStatusTransitService.java
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127323#comment-13127323 ]
jiraposter@reviews.apache.org commented on OOZIE-581:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2386/#review2580
-----------------------------------------------------------
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java
<https://reviews.apache.org/r/2386/#comment5779>
What is the reason for doubling the wait duration?
Can you also add a comment describing the code?
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java
<https://reviews.apache.org/r/2386/#comment5780>
Why is the wait duration 5 seconds here?
Also, can you add a comment describing the code?
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java
<https://reviews.apache.org/r/2386/#comment5781>
Why is the wait duration 5 seconds here?
Also, can you add a comment describing the code?
- Santhosh
On 2011-10-14 00:15:19, Prakhar Sharma wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2386/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-14 00:15:19)
bq.
bq.
bq. Review request for oozie, Mohammad Islam and Angelo K. Huang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Test case TestStatusTransitService::testCoordStatusTransitServiceKilledByUser1() fails due to race condition between status service and the check assertEquals(true, coordJob.isPending()). The kill action has already been completed by the time assertion is checked.
bq.
bq.
bq. This addresses bug OOZIE-581.
bq. https://issues.apache.org/jira/browse/OOZIE-581
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestStatusTransitService.java 1181872
bq.
bq. Diff: https://reviews.apache.org/r/2386/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Prakhar
bq.
bq.
> Fix unit test failure in TestStatusTransitService.java
> ------------------------------------------------------
>
> Key: OOZIE-581
> URL: https://issues.apache.org/jira/browse/OOZIE-581
> Project: Oozie
> Issue Type: Bug
> Reporter: Prakhar Sharma
> Priority: Minor
>
> Test case TestStatusTransitService::testCoordStatusTransitServiceKilledByUser1() fails due to race condition between status service and the check assertEquals(true, coordJob.isPending()). The kill action has already been completed by the time assertion is checked. Working on the fix.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira