You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/03/16 14:15:00 UTC

[jira] [Commented] (DRILL-8409) Support the configuration of bind addresses for network services

    [ https://issues.apache.org/jira/browse/DRILL-8409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701208#comment-17701208 ] 

ASF GitHub Bot commented on DRILL-8409:
---------------------------------------

jnturton opened a new pull request, #2777:
URL: https://github.com/apache/drill/pull/2777

   # [DRILL-8409](https://issues.apache.org/jira/browse/DRILL-8409): Support the configuration of bind addresses for network services
   
   ## Description
   
   Drill provides the DRILL_HOST_NAME env var which determines what Drillbit host name will be exchanged over RPC for later look up by a remote client or Drillbit. This host name is used to check whether Drill is being asked to bind to the loopback address in distributed mode
   ```
       if (isDistributedMode && InetAddress.getByName(hostName).isLoopbackAddress()) {
         throw new DrillbitStartupException("Drillbit is disallowed to bind to loopback address in distributed mode.");
       }
   ```
   but is not ever used set the bind address used for the Drillbit's RPC and web ports! This PR adds new boot options
   ```
   drill.exec.rpc.bind_addr
   drill.exec.http.bind_addr
   ```
   and uses them to set the bind addresses used for RPC services and the HTTP service respectively.
   
   ## Documentation
   Document all three of DRILL_HOST_NAME and the two new bind address options.
   
   ## Testing
   Provide no bind addresses and confirm that the effective previous default (0.0.0.0) is applied.
   Manually set bind addresses and test that Drill is not accessible on other local addresses.
   




> Support the configuration of bind addresses for network services
> ----------------------------------------------------------------
>
>                 Key: DRILL-8409
>                 URL: https://issues.apache.org/jira/browse/DRILL-8409
>             Project: Apache Drill
>          Issue Type: Bug
>          Components:  Server
>    Affects Versions: 1.21.0
>            Reporter: James Turton
>            Assignee: James Turton
>            Priority: Major
>             Fix For: 1.21.1
>
>
> Drill provides the DRILL_HOST_NAME env var which determines what Drillbit host name will be exchanged over RPC for later look up by a remote client or Drillbit. This host name is used to check whether Drill is being asked to bind to the loopback address in distributed mode
> {code:java}
>     if (isDistributedMode && InetAddress.getByName(hostName).isLoopbackAddress()) {
>       throw new DrillbitStartupException("Drillbit is disallowed to bind to loopback address in distributed mode.");
>     }{code}
> but is not subsequently used set the bind address used for the Drillbit's RPC and web ports! This issue proposes that the Drillbit network services bind address is determined by DRILL_HOST_NAME.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)