You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/11/21 07:38:11 UTC

[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #6907: Fix C2S VPN in parallel to S2S VPN

rohityadavcloud commented on code in PR #6907:
URL: https://github.com/apache/cloudstack/pull/6907#discussion_r1027662449


##########
systemvm/debian/opt/cloud/bin/configure.py:
##########
@@ -1002,7 +1002,7 @@ def configure_l2tpIpsec(self, left, obj):
 
         secret = CsFile(vpnsecretfilte)
         secret.empty()
-        secret.addeq("%s : PSK \"%s\"" % (left, psk))
+        secret.addeq(": PSK \"%s\"" % (psk))

Review Comment:
   @GutoVeronezi LGTM, but should we revert to old ? I don't know what the syntax really means 
   ```        secret.addeq("%s %%any : PSK \"%s\"" % (left, psk))
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org