You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by huor <gi...@git.apache.org> on 2016/02/02 16:33:33 UTC
[GitHub] incubator-hawq pull request: HAWQ-386. Remove deprecated catalog t...
GitHub user huor opened a pull request:
https://github.com/apache/incubator-hawq/pull/322
HAWQ-386. Remove deprecated catalog table gp_fault_strategy
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/huor/incubator-hawq huor_catalog
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/322.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #322
----
commit 26d7d9772c7d69c9ae1ec6566f29180b622baa98
Author: Ruilong Huo <rh...@pivotal.io>
Date: 2016-02-02T15:32:34Z
HAWQ-386. Remove deprecated catalog table gp_fault_strategy
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-386. Remove deprecated catalog t...
Posted by liming01 <gi...@git.apache.org>.
Github user liming01 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/322#discussion_r53269798
--- Diff: tools/bin/hawqpylib/system/configurationImplHAWQ.py ---
@@ -276,12 +271,8 @@ def __updateSystemConfigUpdateSegment(self, conn, hawqArray, seg, originalSeg, t
# update mode and status
# when adding a mirror, the replication port may change as well
#
- if hawqArray.getFaultStrategy() == hawqarray.FAULT_STRATEGY_NONE:
- what = "%s: segment hostname and address"
- self.__updateSegmentAddress(conn, seg)
- else:
- what = "%s: segment mode and status"
- self.__updateSegmentModeStatus(conn, seg)
--- End diff --
From the hawq1.x doc, it seems 3 types fault_strategy can be set: nothing / file-based failover / SAN-based failover.
Now we remove this catalog, it means we only have one choice, is it the 'nothing' setting left?
so here in the code, you may keep the wrong branch in the if-else statement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-386. Remove deprecated catalog t...
Posted by linwen <gi...@git.apache.org>.
Github user linwen commented on the pull request:
https://github.com/apache/incubator-hawq/pull/322#issuecomment-185522893
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-386. Remove deprecated catalog t...
Posted by huor <gi...@git.apache.org>.
Github user huor closed the pull request at:
https://github.com/apache/incubator-hawq/pull/322
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---