You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2018/10/12 22:38:38 UTC

[Impala-ASF-CR] IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement 

Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11673


Change subject: IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement
......................................................................

IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement

Change-Id: I203a800855a413069a40c728dfa157939ea15caf
---
M docs/topics/impala_alter_table.xml
M docs/topics/impala_alter_view.xml
2 files changed, 422 insertions(+), 539 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/11673/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I203a800855a413069a40c728dfa157939ea15caf
Gerrit-Change-Number: 11673
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>

[Impala-ASF-CR] IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11673 )

Change subject: IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement
......................................................................


Patch Set 1: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/96/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/11673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I203a800855a413069a40c728dfa157939ea15caf
Gerrit-Change-Number: 11673
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Oct 2018 22:58:28 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Fredy Wijaya, Impala Public Jenkins, Adam Holley, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11673

to look at the new patch set (#3).

Change subject: IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement
......................................................................

IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement

Change-Id: I203a800855a413069a40c728dfa157939ea15caf
---
M docs/topics/impala_alter_table.xml
M docs/topics/impala_alter_view.xml
2 files changed, 424 insertions(+), 539 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/11673/3
-- 
To view, visit http://gerrit.cloudera.org:8080/11673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I203a800855a413069a40c728dfa157939ea15caf
Gerrit-Change-Number: 11673
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11673 )

Change subject: IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement
......................................................................


Patch Set 5:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/106/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/11673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I203a800855a413069a40c728dfa157939ea15caf
Gerrit-Change-Number: 11673
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Oct 2018 22:10:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11673 )

Change subject: IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement
......................................................................


Patch Set 2:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/100/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/11673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I203a800855a413069a40c728dfa157939ea15caf
Gerrit-Change-Number: 11673
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 13 Oct 2018 03:40:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11673 )

Change subject: IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/11673/1/docs/topics/impala_alter_table.xml
File docs/topics/impala_alter_table.xml:

http://gerrit.cloudera.org:8080/#/c/11673/1/docs/topics/impala_alter_table.xml@269
PS1, Line 269:  An
             :       owner of a table has the <codeph>ALL</codeph> privilege
> Also update this similar to the one in ALTER VIEW SET OWNER. We should also
Done


http://gerrit.cloudera.org:8080/#/c/11673/1/docs/topics/impala_alter_view.xml
File docs/topics/impala_alter_view.xml:

http://gerrit.cloudera.org:8080/#/c/11673/1/docs/topics/impala_alter_view.xml@105
PS1, Line 105: An owner of a view has the <codeph>ALL</codeph> privilege
> We can rewrite it like this "When object ownership is enabled in Sentry, an
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/11673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I203a800855a413069a40c728dfa157939ea15caf
Gerrit-Change-Number: 11673
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Oct 2018 21:36:49 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Fredy Wijaya, Impala Public Jenkins, Adam Holley, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11673

to look at the new patch set (#2).

Change subject: IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement
......................................................................

IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement

Change-Id: I203a800855a413069a40c728dfa157939ea15caf
---
M docs/topics/impala_alter_table.xml
M docs/topics/impala_alter_view.xml
2 files changed, 423 insertions(+), 539 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/11673/2
-- 
To view, visit http://gerrit.cloudera.org:8080/11673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I203a800855a413069a40c728dfa157939ea15caf
Gerrit-Change-Number: 11673
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement

Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11673 )

Change subject: IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I203a800855a413069a40c728dfa157939ea15caf
Gerrit-Change-Number: 11673
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Oct 2018 00:59:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11673 )

Change subject: IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/11673/1/docs/topics/impala_alter_table.xml
File docs/topics/impala_alter_table.xml:

http://gerrit.cloudera.org:8080/#/c/11673/1/docs/topics/impala_alter_table.xml@269
PS1, Line 269:  An
             :       owner of a table has the <codeph>ALL</codeph> privilege
> Add "if enabled with Sentry", or something to that effect.
Done


http://gerrit.cloudera.org:8080/#/c/11673/1/docs/topics/impala_alter_view.xml
File docs/topics/impala_alter_view.xml:

http://gerrit.cloudera.org:8080/#/c/11673/1/docs/topics/impala_alter_view.xml@105
PS1, Line 105: An owner of a view has the <codeph>ALL</codeph> privilege
> if enabled with Sentry.
if the ALL privilege is enabled in Sentry? What should be enabled in Sentry?



-- 
To view, visit http://gerrit.cloudera.org:8080/11673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I203a800855a413069a40c728dfa157939ea15caf
Gerrit-Change-Number: 11673
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 13 Oct 2018 03:39:11 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement

Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11673 )

Change subject: IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/11673/1/docs/topics/impala_alter_table.xml
File docs/topics/impala_alter_table.xml:

http://gerrit.cloudera.org:8080/#/c/11673/1/docs/topics/impala_alter_table.xml@269
PS1, Line 269:  An
             :       owner of a table has effectively the <codeph>ALL</codep
> Done
Also update this similar to the one in ALTER VIEW SET OWNER. We should also update the one in ALTER DATABASE SET OWNER.


http://gerrit.cloudera.org:8080/#/c/11673/1/docs/topics/impala_alter_view.xml
File docs/topics/impala_alter_view.xml:

http://gerrit.cloudera.org:8080/#/c/11673/1/docs/topics/impala_alter_view.xml@105
PS1, Line 105: An owner of a view has effectively the <codeph>ALL</codep
> Not a good Sentry doc to link. Waiting for a short info to add here from Fr
We can rewrite it like this "When object ownership is enabled in Sentry, an owner of a view can have "ALL with GRANT" or "ALL without GRANT", but ....".



-- 
To view, visit http://gerrit.cloudera.org:8080/11673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I203a800855a413069a40c728dfa157939ea15caf
Gerrit-Change-Number: 11673
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Oct 2018 17:33:13 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11673 )

Change subject: IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement
......................................................................


Patch Set 3: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/102/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/11673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I203a800855a413069a40c728dfa157939ea15caf
Gerrit-Change-Number: 11673
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Oct 2018 22:00:12 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11673 )

Change subject: IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement
......................................................................


Patch Set 2: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/100/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/11673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I203a800855a413069a40c728dfa157939ea15caf
Gerrit-Change-Number: 11673
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 13 Oct 2018 03:51:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11673 )

Change subject: IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement
......................................................................


Patch Set 4:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/103/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/11673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I203a800855a413069a40c728dfa157939ea15caf
Gerrit-Change-Number: 11673
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Oct 2018 21:36:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement

Posted by "Adam Holley (Code Review)" <ge...@cloudera.org>.
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11673 )

Change subject: IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11673/1/docs/topics/impala_alter_view.xml
File docs/topics/impala_alter_view.xml:

http://gerrit.cloudera.org:8080/#/c/11673/1/docs/topics/impala_alter_view.xml@105
PS1, Line 105: An owner of a view has the <codeph>ALL</codeph> privilege
> if the ALL privilege is enabled in Sentry? What should be enabled in Sentry
Object ownership in Sentry is controlled with one of three options.  all_with_grant, all, or none.  But I think this should be documented in Sentry and linked to from here because you can't control through Impala config.



-- 
To view, visit http://gerrit.cloudera.org:8080/11673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I203a800855a413069a40c728dfa157939ea15caf
Gerrit-Change-Number: 11673
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Oct 2018 16:57:48 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11673 )

Change subject: IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement
......................................................................


Patch Set 4: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/103/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/11673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I203a800855a413069a40c728dfa157939ea15caf
Gerrit-Change-Number: 11673
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Oct 2018 21:47:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11673 )

Change subject: IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/11673/2/docs/topics/impala_alter_table.xml
File docs/topics/impala_alter_table.xml:

http://gerrit.cloudera.org:8080/#/c/11673/2/docs/topics/impala_alter_table.xml@270
PS2, Line 270: the <codeph>ALL</codeph> privilege
> maybe rename to "effectively ALL privilege"?
Done


http://gerrit.cloudera.org:8080/#/c/11673/1/docs/topics/impala_alter_view.xml
File docs/topics/impala_alter_view.xml:

http://gerrit.cloudera.org:8080/#/c/11673/1/docs/topics/impala_alter_view.xml@105
PS1, Line 105: An owner of a view has the <codeph>ALL</codeph> privilege
> Object ownership in Sentry is controlled with one of three options.  all_wi
Not a good Sentry doc to link. Waiting for a short info to add here from Fredy.


http://gerrit.cloudera.org:8080/#/c/11673/2/docs/topics/impala_alter_view.xml
File docs/topics/impala_alter_view.xml:

http://gerrit.cloudera.org:8080/#/c/11673/2/docs/topics/impala_alter_view.xml@105
PS2, Line 105: the <codeph>ALL</codeph> privilege
> maybe rename to "effectively ALL privilege"?
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/11673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I203a800855a413069a40c728dfa157939ea15caf
Gerrit-Change-Number: 11673
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Oct 2018 21:31:18 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement

Posted by "Adam Holley (Code Review)" <ge...@cloudera.org>.
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11673 )

Change subject: IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/11673/1/docs/topics/impala_alter_table.xml
File docs/topics/impala_alter_table.xml:

http://gerrit.cloudera.org:8080/#/c/11673/1/docs/topics/impala_alter_table.xml@269
PS1, Line 269:  An
             :       owner of a table has the <codeph>ALL</codeph> privilege
Add "if enabled with Sentry", or something to that effect.


http://gerrit.cloudera.org:8080/#/c/11673/1/docs/topics/impala_alter_view.xml
File docs/topics/impala_alter_view.xml:

http://gerrit.cloudera.org:8080/#/c/11673/1/docs/topics/impala_alter_view.xml@105
PS1, Line 105: An owner of a view has the <codeph>ALL</codeph> privilege
if enabled with Sentry.



-- 
To view, visit http://gerrit.cloudera.org:8080/11673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I203a800855a413069a40c728dfa157939ea15caf
Gerrit-Change-Number: 11673
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 13 Oct 2018 03:01:28 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11673 )

Change subject: IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement
......................................................................


Patch Set 5: Verified+1

Build Successful 

https://jenkins.impala.io/job/gerrit-docs-auto-test/106/ : Doc tests passed.


-- 
To view, visit http://gerrit.cloudera.org:8080/11673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I203a800855a413069a40c728dfa157939ea15caf
Gerrit-Change-Number: 11673
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Oct 2018 22:54:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Fredy Wijaya, Impala Public Jenkins, Adam Holley, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11673

to look at the new patch set (#5).

Change subject: IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement
......................................................................

IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement

Change-Id: I203a800855a413069a40c728dfa157939ea15caf
---
M docs/topics/impala_alter_table.xml
M docs/topics/impala_alter_view.xml
2 files changed, 443 insertions(+), 316 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/11673/5
-- 
To view, visit http://gerrit.cloudera.org:8080/11673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I203a800855a413069a40c728dfa157939ea15caf
Gerrit-Change-Number: 11673
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement

Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11673 )

Change subject: IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/11673/2/docs/topics/impala_alter_table.xml
File docs/topics/impala_alter_table.xml:

http://gerrit.cloudera.org:8080/#/c/11673/2/docs/topics/impala_alter_table.xml@270
PS2, Line 270: the <codeph>ALL</codeph> privilege
maybe rename to "effectively ALL privilege"?


http://gerrit.cloudera.org:8080/#/c/11673/2/docs/topics/impala_alter_view.xml
File docs/topics/impala_alter_view.xml:

http://gerrit.cloudera.org:8080/#/c/11673/2/docs/topics/impala_alter_view.xml@105
PS2, Line 105: the <codeph>ALL</codeph> privilege
maybe rename to "effectively ALL privilege"?



-- 
To view, visit http://gerrit.cloudera.org:8080/11673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I203a800855a413069a40c728dfa157939ea15caf
Gerrit-Change-Number: 11673
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Oct 2018 15:42:28 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11673 )

Change subject: IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement
......................................................................


Patch Set 3:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/102/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/11673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I203a800855a413069a40c728dfa157939ea15caf
Gerrit-Change-Number: 11673
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Oct 2018 21:31:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11673 )

Change subject: IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement
......................................................................


Patch Set 1:

Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/96/ 

Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317


-- 
To view, visit http://gerrit.cloudera.org:8080/11673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I203a800855a413069a40c728dfa157939ea15caf
Gerrit-Change-Number: 11673
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Oct 2018 22:38:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11673 )

Change subject: IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement
......................................................................

IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement

Change-Id: I203a800855a413069a40c728dfa157939ea15caf
Reviewed-on: http://gerrit.cloudera.org:8080/11673
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Fredy Wijaya <fw...@cloudera.com>
---
M docs/topics/impala_alter_table.xml
M docs/topics/impala_alter_view.xml
2 files changed, 443 insertions(+), 316 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Fredy Wijaya: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/11673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I203a800855a413069a40c728dfa157939ea15caf
Gerrit-Change-Number: 11673
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement

Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Fredy Wijaya, Impala Public Jenkins, Adam Holley, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11673

to look at the new patch set (#4).

Change subject: IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement
......................................................................

IMPALA-7076: [DOCS] Document ALTER TABLE / VIEW SET OWNER statement

Change-Id: I203a800855a413069a40c728dfa157939ea15caf
---
M docs/topics/impala_alter_table.xml
M docs/topics/impala_alter_view.xml
2 files changed, 444 insertions(+), 316 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/11673/4
-- 
To view, visit http://gerrit.cloudera.org:8080/11673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I203a800855a413069a40c728dfa157939ea15caf
Gerrit-Change-Number: 11673
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Adam Holley <ah...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>