[GitHub] [jena] kinow commented on a diff in pull request #1714: Fix for timezone adjusting

[GitBox <gi...@apache.org>]

kinow commented on code in PR #1714:
URL: https://github.com/apache/jena/pull/1714#discussion_r1066285378


##########
jena-arq/src/main/java/org/apache/jena/sparql/expr/nodevalue/XSDFuncOp.java:
##########
@@ -1171,12 +1168,12 @@ public static int compareDateTimeFO(NodeValue nv1, NodeValue nv2) {
         return x ;
     }
 
-    /** Return a normalized XMLGregorianCalendar appropriate for comparision */
+    /** Return a normalized XMLGregorianCalendar appropriate for F&O comparision using teh XSD algorithm. */

Review Comment:
   s/comparision/comparison (not added in this PR, but worth fixing?). Also s/teh/the



##########
jena-arq/src/main/java/org/apache/jena/sparql/function/StandardFunctions.java:
##########
@@ -41,6 +41,13 @@
      * and sparql:* for all the SPARQL builtins.
      */
 
+    public static void loadOtherDefs(FunctionRegistry registry) {
+        // Only need to add functions that are not in org.apache.jena.sparql.function.library or have nemas that are not java-compliant

Review Comment:
   s/nemas/names



##########
jena-arq/src/main/java/org/apache/jena/sparql/function/library/AFN_SystemTimezone.java:
##########
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.jena.sparql.function.library;
+
+import org.apache.jena.sparql.expr.NodeValue;
+import org.apache.jena.sparql.expr.nodevalue.XSDFuncOp;
+import org.apache.jena.sparql.function.FunctionBase0;
+
+public class AFN_SystemTimezone extends FunctionBase0 {
+
+    public AFN_SystemTimezone() {
+        super();
+    }
+
+    @Override
+    public NodeValue exec() {
+        return XSDFuncOp.localSystemTimezone();
+    }
+
+

Review Comment:
   Extra line, but doesn't matter.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org