You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/17 18:15:34 UTC
[GitHub] [spark] Kimahriman opened a new pull request #35901: [SPARK-38194] Followup: Fix k8s memory overhead passing to executor pods
Kimahriman opened a new pull request #35901:
URL: https://github.com/apache/spark/pull/35901
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Follow up to https://github.com/apache/spark/pull/35504 to fix k8s memory overhead handling.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
https://github.com/apache/spark/pull/35504 introduced a bug only caught by the K8S integration tests.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Fix back to old behavior.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
See if IT passes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on a change in pull request #35901: [SPARK-38194] Followup: Fix k8s memory overhead passing to executor pods
Posted by GitBox <gi...@apache.org>.
tgravescs commented on a change in pull request #35901:
URL: https://github.com/apache/spark/pull/35901#discussion_r829402111
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
##########
@@ -53,28 +53,31 @@ private[spark] class BasicDriverFeatureStep(conf: KubernetesDriverConf)
// Memory settings
private val driverMemoryMiB = conf.get(DRIVER_MEMORY)
- private val memoryOverheadFactor = if (conf.contains(DRIVER_MEMORY_OVERHEAD_FACTOR)) {
- conf.get(DRIVER_MEMORY_OVERHEAD_FACTOR)
- } else {
- conf.get(MEMORY_OVERHEAD_FACTOR)
- }
- // The memory overhead factor to use. If the user has not set it, then use a different
- // value for non-JVM apps. This value is propagated to executors.
- private val overheadFactor =
+ // The default memory overhead factor to use. If the user has not set it, then use a different
+ // value for non-JVM apps. This value is propagated to executors and used if the executor
+ // overhead factor is not set explicitly.
+ private val defaultOverheadFactor =
Review comment:
looks good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] asfgit closed pull request #35901: [SPARK-38194] Followup: Fix k8s memory overhead passing to executor pods
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #35901:
URL: https://github.com/apache/spark/pull/35901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #35901: [SPARK-38194] Followup: Fix k8s memory overhead passing to executor pods
Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #35901:
URL: https://github.com/apache/spark/pull/35901#issuecomment-1071909046
Thanks for your fix, late LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on a change in pull request #35901: [SPARK-38194] Followup: Fix k8s memory overhead passing to executor pods
Posted by GitBox <gi...@apache.org>.
Yikun commented on a change in pull request #35901:
URL: https://github.com/apache/spark/pull/35901#discussion_r829614803
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
##########
@@ -53,28 +53,32 @@ private[spark] class BasicDriverFeatureStep(conf: KubernetesDriverConf)
// Memory settings
private val driverMemoryMiB = conf.get(DRIVER_MEMORY)
- private val memoryOverheadFactor = if (conf.contains(DRIVER_MEMORY_OVERHEAD_FACTOR)) {
- conf.get(DRIVER_MEMORY_OVERHEAD_FACTOR)
- } else {
- conf.get(MEMORY_OVERHEAD_FACTOR)
- }
- // The memory overhead factor to use. If the user has not set it, then use a different
- // value for non-JVM apps. This value is propagated to executors.
- private val overheadFactor =
+ // The default memory overhead factor to use, derived from the deprecated
Review comment:
nice note!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Kimahriman commented on a change in pull request #35901: [SPARK-38194] Followup: Fix k8s memory overhead passing to executor pods
Posted by GitBox <gi...@apache.org>.
Kimahriman commented on a change in pull request #35901:
URL: https://github.com/apache/spark/pull/35901#discussion_r829378335
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
##########
@@ -53,28 +53,31 @@ private[spark] class BasicDriverFeatureStep(conf: KubernetesDriverConf)
// Memory settings
private val driverMemoryMiB = conf.get(DRIVER_MEMORY)
- private val memoryOverheadFactor = if (conf.contains(DRIVER_MEMORY_OVERHEAD_FACTOR)) {
- conf.get(DRIVER_MEMORY_OVERHEAD_FACTOR)
- } else {
- conf.get(MEMORY_OVERHEAD_FACTOR)
- }
- // The memory overhead factor to use. If the user has not set it, then use a different
- // value for non-JVM apps. This value is propagated to executors.
- private val overheadFactor =
+ // The default memory overhead factor to use. If the user has not set it, then use a different
+ // value for non-JVM apps. This value is propagated to executors and used if the executor
+ // overhead factor is not set explicitly.
+ private val defaultOverheadFactor =
Review comment:
yeah it definitely seems weird that this isn't just handled in the BasicExecutorFeatureStep, but someone who actually uses k8s can try to update that. I can update the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on a change in pull request #35901: [SPARK-38194] Followup: Fix k8s memory overhead passing to executor pods
Posted by GitBox <gi...@apache.org>.
tgravescs commented on a change in pull request #35901:
URL: https://github.com/apache/spark/pull/35901#discussion_r829372761
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
##########
@@ -53,28 +53,31 @@ private[spark] class BasicDriverFeatureStep(conf: KubernetesDriverConf)
// Memory settings
private val driverMemoryMiB = conf.get(DRIVER_MEMORY)
- private val memoryOverheadFactor = if (conf.contains(DRIVER_MEMORY_OVERHEAD_FACTOR)) {
- conf.get(DRIVER_MEMORY_OVERHEAD_FACTOR)
- } else {
- conf.get(MEMORY_OVERHEAD_FACTOR)
- }
- // The memory overhead factor to use. If the user has not set it, then use a different
- // value for non-JVM apps. This value is propagated to executors.
- private val overheadFactor =
+ // The default memory overhead factor to use. If the user has not set it, then use a different
+ // value for non-JVM apps. This value is propagated to executors and used if the executor
+ // overhead factor is not set explicitly.
+ private val defaultOverheadFactor =
Review comment:
yes this is exactly what I was thinking originally, but then I realized that if the default values for driver vs executor were to ever change in the new configs this wouldn't handle that. So that is why it might actually be better to check in the BasicExecutorFeatureStep. I'm ok with doing that as a followup though as this fixes the issue and both have the same default.
one thing we may want to add comment above saying this is either the setting of old config or the default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Kimahriman commented on pull request #35901: [SPARK-38194] Followup: Fix k8s memory overhead passing to executor pods
Posted by GitBox <gi...@apache.org>.
Kimahriman commented on pull request #35901:
URL: https://github.com/apache/spark/pull/35901#issuecomment-1071258716
Think I need to fix the test for this too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #35901: [SPARK-38194] Followup: Fix k8s memory overhead passing to executor pods
Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #35901:
URL: https://github.com/apache/spark/pull/35901#issuecomment-1071912218
FYI, master CI passed in K8S IT,
https://github.com/Yikun/spark/actions/runs/2001425290
We might want to backport this with squash previous revert patch to 3.3 if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on a change in pull request #35901: [SPARK-38194] Followup: Fix k8s memory overhead passing to executor pods
Posted by GitBox <gi...@apache.org>.
Yikun commented on a change in pull request #35901:
URL: https://github.com/apache/spark/pull/35901#discussion_r829614803
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
##########
@@ -53,28 +53,32 @@ private[spark] class BasicDriverFeatureStep(conf: KubernetesDriverConf)
// Memory settings
private val driverMemoryMiB = conf.get(DRIVER_MEMORY)
- private val memoryOverheadFactor = if (conf.contains(DRIVER_MEMORY_OVERHEAD_FACTOR)) {
- conf.get(DRIVER_MEMORY_OVERHEAD_FACTOR)
- } else {
- conf.get(MEMORY_OVERHEAD_FACTOR)
- }
- // The memory overhead factor to use. If the user has not set it, then use a different
- // value for non-JVM apps. This value is propagated to executors.
- private val overheadFactor =
+ // The default memory overhead factor to use, derived from the deprecated
Review comment:
nice note!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on a change in pull request #35901: [SPARK-38194] Followup: Fix k8s memory overhead passing to executor pods
Posted by GitBox <gi...@apache.org>.
tgravescs commented on a change in pull request #35901:
URL: https://github.com/apache/spark/pull/35901#discussion_r829372761
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
##########
@@ -53,28 +53,31 @@ private[spark] class BasicDriverFeatureStep(conf: KubernetesDriverConf)
// Memory settings
private val driverMemoryMiB = conf.get(DRIVER_MEMORY)
- private val memoryOverheadFactor = if (conf.contains(DRIVER_MEMORY_OVERHEAD_FACTOR)) {
- conf.get(DRIVER_MEMORY_OVERHEAD_FACTOR)
- } else {
- conf.get(MEMORY_OVERHEAD_FACTOR)
- }
- // The memory overhead factor to use. If the user has not set it, then use a different
- // value for non-JVM apps. This value is propagated to executors.
- private val overheadFactor =
+ // The default memory overhead factor to use. If the user has not set it, then use a different
+ // value for non-JVM apps. This value is propagated to executors and used if the executor
+ // overhead factor is not set explicitly.
+ private val defaultOverheadFactor =
Review comment:
yes this is exactly what I was thinking originally, but then I realized that if the default values for driver vs executor were to ever change ion the new configs this wouldn't handle that. So that is why it might actually be better to check in the BasicExecutorFeatureStep. I'm ok with doing that as a followup though as this fixes the issue and both have the same default.
one thing we may want to add comment above saying this is either the setting of old config or the default.
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
##########
@@ -53,28 +53,31 @@ private[spark] class BasicDriverFeatureStep(conf: KubernetesDriverConf)
// Memory settings
private val driverMemoryMiB = conf.get(DRIVER_MEMORY)
- private val memoryOverheadFactor = if (conf.contains(DRIVER_MEMORY_OVERHEAD_FACTOR)) {
- conf.get(DRIVER_MEMORY_OVERHEAD_FACTOR)
- } else {
- conf.get(MEMORY_OVERHEAD_FACTOR)
- }
- // The memory overhead factor to use. If the user has not set it, then use a different
- // value for non-JVM apps. This value is propagated to executors.
- private val overheadFactor =
+ // The default memory overhead factor to use. If the user has not set it, then use a different
+ // value for non-JVM apps. This value is propagated to executors and used if the executor
+ // overhead factor is not set explicitly.
+ private val defaultOverheadFactor =
Review comment:
yes this is exactly what I was thinking originally, but then I realized that if the default values for driver vs executor were to ever change in the new configs this wouldn't handle that. So that is why it might actually be better to check in the BasicExecutorFeatureStep. I'm ok with doing that as a followup though as this fixes the issue and both have the same default.
one thing we may want to add comment above saying this is either the setting of old config or the default.
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
##########
@@ -53,28 +53,31 @@ private[spark] class BasicDriverFeatureStep(conf: KubernetesDriverConf)
// Memory settings
private val driverMemoryMiB = conf.get(DRIVER_MEMORY)
- private val memoryOverheadFactor = if (conf.contains(DRIVER_MEMORY_OVERHEAD_FACTOR)) {
- conf.get(DRIVER_MEMORY_OVERHEAD_FACTOR)
- } else {
- conf.get(MEMORY_OVERHEAD_FACTOR)
- }
- // The memory overhead factor to use. If the user has not set it, then use a different
- // value for non-JVM apps. This value is propagated to executors.
- private val overheadFactor =
+ // The default memory overhead factor to use. If the user has not set it, then use a different
+ // value for non-JVM apps. This value is propagated to executors and used if the executor
+ // overhead factor is not set explicitly.
+ private val defaultOverheadFactor =
Review comment:
looks good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35901: [SPARK-38194] Followup: Fix k8s memory overhead passing to executor pods
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35901:
URL: https://github.com/apache/spark/pull/35901#issuecomment-1072878566
No, it is a legitimate backporting request, @tgravescs .
To @Kimahriman , as @Yikun mentioned, could you make a single healthy backporting PR to `branch-3.3`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35901: [SPARK-38194] Followup: Fix k8s memory overhead passing to executor pods
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35901:
URL: https://github.com/apache/spark/pull/35901#issuecomment-1072882957
Apache Spark merge-script will squash for you. You can make a PR with all commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Kimahriman commented on pull request #35901: [SPARK-38194] Followup: Fix k8s memory overhead passing to executor pods
Posted by GitBox <gi...@apache.org>.
Kimahriman commented on pull request #35901:
URL: https://github.com/apache/spark/pull/35901#issuecomment-1072880527
Yeah I can do that. Do I need to combine the commits myself or do you just squash everything when you merge anyway?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on pull request #35901: [SPARK-38194] Followup: Fix k8s memory overhead passing to executor pods
Posted by GitBox <gi...@apache.org>.
tgravescs commented on pull request #35901:
URL: https://github.com/apache/spark/pull/35901#issuecomment-1071829243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #35901: [SPARK-38194] Followup: Fix k8s memory overhead passing to executor pods
Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #35901:
URL: https://github.com/apache/spark/pull/35901#issuecomment-1071909046
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Kimahriman commented on pull request #35901: [SPARK-38194] Followup: Fix k8s memory overhead passing to executor pods
Posted by GitBox <gi...@apache.org>.
Kimahriman commented on pull request #35901:
URL: https://github.com/apache/spark/pull/35901#issuecomment-1072885716
That's what I thought, just wanted to make sure!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Kimahriman commented on pull request #35901: [SPARK-38194] Followup: Fix k8s memory overhead passing to executor pods
Posted by GitBox <gi...@apache.org>.
Kimahriman commented on pull request #35901:
URL: https://github.com/apache/spark/pull/35901#issuecomment-1071177378
@tgravescs is this what you were thinking?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on pull request #35901: [SPARK-38194] Followup: Fix k8s memory overhead passing to executor pods
Posted by GitBox <gi...@apache.org>.
tgravescs commented on pull request #35901:
URL: https://github.com/apache/spark/pull/35901#issuecomment-1071829243
merged to master, thanks @Kimahriman
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] asfgit closed pull request #35901: [SPARK-38194] Followup: Fix k8s memory overhead passing to executor pods
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #35901:
URL: https://github.com/apache/spark/pull/35901
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Kimahriman commented on a change in pull request #35901: [SPARK-38194] Followup: Fix k8s memory overhead passing to executor pods
Posted by GitBox <gi...@apache.org>.
Kimahriman commented on a change in pull request #35901:
URL: https://github.com/apache/spark/pull/35901#discussion_r829404258
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
##########
@@ -53,28 +53,31 @@ private[spark] class BasicDriverFeatureStep(conf: KubernetesDriverConf)
// Memory settings
private val driverMemoryMiB = conf.get(DRIVER_MEMORY)
- private val memoryOverheadFactor = if (conf.contains(DRIVER_MEMORY_OVERHEAD_FACTOR)) {
- conf.get(DRIVER_MEMORY_OVERHEAD_FACTOR)
- } else {
- conf.get(MEMORY_OVERHEAD_FACTOR)
- }
- // The memory overhead factor to use. If the user has not set it, then use a different
- // value for non-JVM apps. This value is propagated to executors.
- private val overheadFactor =
+ // The default memory overhead factor to use. If the user has not set it, then use a different
+ // value for non-JVM apps. This value is propagated to executors and used if the executor
+ // overhead factor is not set explicitly.
+ private val defaultOverheadFactor =
Review comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Kimahriman commented on a change in pull request #35901: [SPARK-38194] Followup: Fix k8s memory overhead passing to executor pods
Posted by GitBox <gi...@apache.org>.
Kimahriman commented on a change in pull request #35901:
URL: https://github.com/apache/spark/pull/35901#discussion_r829381575
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
##########
@@ -53,28 +53,31 @@ private[spark] class BasicDriverFeatureStep(conf: KubernetesDriverConf)
// Memory settings
private val driverMemoryMiB = conf.get(DRIVER_MEMORY)
- private val memoryOverheadFactor = if (conf.contains(DRIVER_MEMORY_OVERHEAD_FACTOR)) {
- conf.get(DRIVER_MEMORY_OVERHEAD_FACTOR)
- } else {
- conf.get(MEMORY_OVERHEAD_FACTOR)
- }
- // The memory overhead factor to use. If the user has not set it, then use a different
- // value for non-JVM apps. This value is propagated to executors.
- private val overheadFactor =
+ // The default memory overhead factor to use. If the user has not set it, then use a different
+ // value for non-JVM apps. This value is propagated to executors and used if the executor
+ // overhead factor is not set explicitly.
+ private val defaultOverheadFactor =
Review comment:
```
// The default memory overhead factor to use, derived from the deprecated
// `spark.kubernetes.memoryOverheadFactor` config or the default overhead values.
// If the user has not set it, then use a different default for non-JVM apps. This value is
// propagated to executors and used if the executor overhead factor is not set explicitly.
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on a change in pull request #35901: [SPARK-38194] Followup: Fix k8s memory overhead passing to executor pods
Posted by GitBox <gi...@apache.org>.
tgravescs commented on a change in pull request #35901:
URL: https://github.com/apache/spark/pull/35901#discussion_r829372761
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
##########
@@ -53,28 +53,31 @@ private[spark] class BasicDriverFeatureStep(conf: KubernetesDriverConf)
// Memory settings
private val driverMemoryMiB = conf.get(DRIVER_MEMORY)
- private val memoryOverheadFactor = if (conf.contains(DRIVER_MEMORY_OVERHEAD_FACTOR)) {
- conf.get(DRIVER_MEMORY_OVERHEAD_FACTOR)
- } else {
- conf.get(MEMORY_OVERHEAD_FACTOR)
- }
- // The memory overhead factor to use. If the user has not set it, then use a different
- // value for non-JVM apps. This value is propagated to executors.
- private val overheadFactor =
+ // The default memory overhead factor to use. If the user has not set it, then use a different
+ // value for non-JVM apps. This value is propagated to executors and used if the executor
+ // overhead factor is not set explicitly.
+ private val defaultOverheadFactor =
Review comment:
yes this is exactly what I was thinking originally, but then I realized that if the default values for driver vs executor were to ever change ion the new configs this wouldn't handle that. So that is why it might actually be better to check in the BasicExecutorFeatureStep. I'm ok with doing that as a followup though as this fixes the issue and both have the same default.
one thing we may want to add comment above saying this is either the setting of old config or the default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Kimahriman commented on pull request #35901: [SPARK-38194] Followup: Fix k8s memory overhead passing to executor pods
Posted by GitBox <gi...@apache.org>.
Kimahriman commented on pull request #35901:
URL: https://github.com/apache/spark/pull/35901#issuecomment-1071177378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on pull request #35901: [SPARK-38194] Followup: Fix k8s memory overhead passing to executor pods
Posted by GitBox <gi...@apache.org>.
tgravescs commented on pull request #35901:
URL: https://github.com/apache/spark/pull/35901#issuecomment-1072431754
@dongjoon-hyun do you have any concerns with pulling into 3.3 at this point?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Kimahriman commented on a change in pull request #35901: [SPARK-38194] Followup: Fix k8s memory overhead passing to executor pods
Posted by GitBox <gi...@apache.org>.
Kimahriman commented on a change in pull request #35901:
URL: https://github.com/apache/spark/pull/35901#discussion_r829378335
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
##########
@@ -53,28 +53,31 @@ private[spark] class BasicDriverFeatureStep(conf: KubernetesDriverConf)
// Memory settings
private val driverMemoryMiB = conf.get(DRIVER_MEMORY)
- private val memoryOverheadFactor = if (conf.contains(DRIVER_MEMORY_OVERHEAD_FACTOR)) {
- conf.get(DRIVER_MEMORY_OVERHEAD_FACTOR)
- } else {
- conf.get(MEMORY_OVERHEAD_FACTOR)
- }
- // The memory overhead factor to use. If the user has not set it, then use a different
- // value for non-JVM apps. This value is propagated to executors.
- private val overheadFactor =
+ // The default memory overhead factor to use. If the user has not set it, then use a different
+ // value for non-JVM apps. This value is propagated to executors and used if the executor
+ // overhead factor is not set explicitly.
+ private val defaultOverheadFactor =
Review comment:
yeah it definitely seems weird that this isn't just handled in the BasicExecutorFeatureStep, but someone who actually uses k8s can try to update that. I can update the comment.
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
##########
@@ -53,28 +53,31 @@ private[spark] class BasicDriverFeatureStep(conf: KubernetesDriverConf)
// Memory settings
private val driverMemoryMiB = conf.get(DRIVER_MEMORY)
- private val memoryOverheadFactor = if (conf.contains(DRIVER_MEMORY_OVERHEAD_FACTOR)) {
- conf.get(DRIVER_MEMORY_OVERHEAD_FACTOR)
- } else {
- conf.get(MEMORY_OVERHEAD_FACTOR)
- }
- // The memory overhead factor to use. If the user has not set it, then use a different
- // value for non-JVM apps. This value is propagated to executors.
- private val overheadFactor =
+ // The default memory overhead factor to use. If the user has not set it, then use a different
+ // value for non-JVM apps. This value is propagated to executors and used if the executor
+ // overhead factor is not set explicitly.
+ private val defaultOverheadFactor =
Review comment:
```
// The default memory overhead factor to use, derived from the deprecated
// `spark.kubernetes.memoryOverheadFactor` config or the default overhead values.
// If the user has not set it, then use a different default for non-JVM apps. This value is
// propagated to executors and used if the executor overhead factor is not set explicitly.
```
?
##########
File path: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
##########
@@ -53,28 +53,31 @@ private[spark] class BasicDriverFeatureStep(conf: KubernetesDriverConf)
// Memory settings
private val driverMemoryMiB = conf.get(DRIVER_MEMORY)
- private val memoryOverheadFactor = if (conf.contains(DRIVER_MEMORY_OVERHEAD_FACTOR)) {
- conf.get(DRIVER_MEMORY_OVERHEAD_FACTOR)
- } else {
- conf.get(MEMORY_OVERHEAD_FACTOR)
- }
- // The memory overhead factor to use. If the user has not set it, then use a different
- // value for non-JVM apps. This value is propagated to executors.
- private val overheadFactor =
+ // The default memory overhead factor to use. If the user has not set it, then use a different
+ // value for non-JVM apps. This value is propagated to executors and used if the executor
+ // overhead factor is not set explicitly.
+ private val defaultOverheadFactor =
Review comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org