[GitHub] [helix] pkuwm commented on a change in pull request #973: TaskStateModelFactory configurable thread pool size

[GitBox <gi...@apache.org>]

pkuwm commented on a change in pull request #973:
URL: https://github.com/apache/helix/pull/973#discussion_r420278332



##########
File path: helix-core/src/test/java/org/apache/helix/task/TestTaskStateModelFactory.java
##########
@@ -0,0 +1,95 @@
+package org.apache.helix.task;
+

Review comment:
       Apache license?

##########
File path: helix-core/src/main/java/org/apache/helix/model/LiveInstance.java
##########
@@ -48,6 +49,7 @@
     TASK_EXEC_THREAD
   }
 
+  public static final int CURRENT_TASK_THREAD_POOL_SIZE_NOT_SET = -1;

Review comment:
       I see 2 not set constants. Did you consider using one common constant and putting it in the constants class?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org