You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/18 02:57:34 UTC

[GitHub] [apisix] Firstsawyou opened a new issue #2778: DISCUSS(kafka-logger): the key field should be optional

Firstsawyou opened a new issue #2778:
URL: https://github.com/apache/apisix/issues/2778


   ### Issue description
   
   In the schema of the kafka-logger plugin, the key field is mandatory, as shown below:
   
   ```
   ......
       properties = {
           ......
           key = {type = "string"},
           ......
       },
       required = {"broker_list", "kafka_topic", "key"}
   ......
   ```
   
   I think the key field should be optional, because when a message is sent to the Kafka service, the key can be specified or empty. So when the key is empty, it can be used normally.
   
   The key should be optional in the schemaļ¼š
   
   ```
   ......
       properties = {
           ......
           key = {type = "string"},
           ......
       },
       required = {"broker_list", "kafka_topic"}
   ......
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] moonming commented on issue #2778: DISCUSS(kafka-logger): the key field should be optional

Posted by GitBox <gi...@apache.org>.
moonming commented on issue #2778:
URL: https://github.com/apache/apisix/issues/2778#issuecomment-731559519


   please send discuss thread to mailinglist


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander closed issue #2778: DISCUSS(kafka-logger): the key field should be optional

Posted by GitBox <gi...@apache.org>.
spacewander closed issue #2778:
URL: https://github.com/apache/apisix/issues/2778


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org