svn commit: r1903743 - /pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/multipdf/Overlay.java

[ti...@apache.org]

Author: tilman
Date: Sun Aug 28 17:28:40 2022
New Revision: 1903743

URL: http://svn.apache.org/viewvc?rev=1903743&view=rev
Log:
PDFBOX-4892: optimize, as suggested by Valery Bokov

Modified:
    pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/multipdf/Overlay.java

Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/multipdf/Overlay.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/multipdf/Overlay.java?rev=1903743&r1=1903742&r2=1903743&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/multipdf/Overlay.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/multipdf/Overlay.java Sun Aug 28 17:28:40 2022
@@ -25,6 +25,7 @@ import java.io.OutputStream;
 import java.math.BigDecimal;
 import java.nio.charset.StandardCharsets;
 import java.util.ArrayList;
+import java.util.Collections;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.List;
@@ -353,16 +354,17 @@ public class Overlay implements Closeabl
     // get the content streams as a list
     private List<COSStream> createContentStreamList(COSBase contents) throws IOException
     {
-        List<COSStream> contentStreams = new ArrayList<>();
         if (contents == null)
         {
-            return contentStreams;
+            return Collections.emptyList();
         }
-        else if (contents instanceof COSStream)
+        if (contents instanceof COSStream)
         {
-            contentStreams.add((COSStream) contents);
+            return Collections.singletonList((COSStream) contents);
         }
-        else if (contents instanceof COSArray)
+
+        List<COSStream> contentStreams = new ArrayList<>();
+        if (contents instanceof COSArray)
         {
             for (COSBase item : (COSArray) contents)
             {