You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/11/12 10:19:39 UTC
[GitHub] [cloudstack] weizhouapache opened a new pull request #5684: kvm: add hosts using cloustack ssh private key
weizhouapache opened a new pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684
### Description
This PR provides the option to add kvm hosts with empty or wrong password.
To support this, the cloudstack ssh public key needs to be added in the ~/.ssh/authorized_keys on host.
Thanks @rhtyd for the idea !
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
### Screenshots (if appropriate):
1. get cloudstack public key from management server (/var/lib/cloudstack/management/.ssh/id_rsa.pub)
2. add the key to ~/.ssh/authorized_keys on kvm hosts
3. add kvm host with empty password
<img src="https://user-images.githubusercontent.com/57355700/141449865-6ffee1f0-b0d7-4ea4-b11a-32df42e2fe91.png" height="50%" width="50%">
### How Has This Been Tested?
1. add host, with correct password, works as expected.
2. put host to maitenance, stop cloudstack-agent, cancel maintenance, remove the host. all work.
3. add host, with empty password (ssh public key is added to ~/.ssh/authorized_keys), works as expected.
4. put host to maitenance, stop cloudstack-agent, cancel maintenance. all work as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #5684: (ccc2021 hachathon ) kvm: add hosts using cloustack ssh private key
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#discussion_r748158444
##########
File path: utils/src/main/java/com/cloud/utils/ssh/SSHCmdHelper.java
##########
@@ -77,8 +80,47 @@ public String getStdErr() {
}
public static com.trilead.ssh2.Connection acquireAuthorizedConnection(String ip, int port, String username, String password) {
+ return acquireAuthorizedConnection(ip, 22, username, password, null);
+ }
+
+ public static boolean acquireAuthorizedConnectionWithPublicKey(final com.trilead.ssh2.Connection sshConnection, final String username, final String privateKey) {
+ if (StringUtils.isNotBlank(privateKey)) {
+ File privateKeyFile = null;
+ try {
+ privateKeyFile = File.createTempFile("cloudstack-host-", null);
Review comment:
Note: needs checking on all distros (this path), on centos7, centos/rocky8, ubuntu and suse. cc @davidjumani if you know/remember distro specific paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5684: (ccc2021 hachathon ) kvm: add hosts using cloustack ssh private key
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#discussion_r748177170
##########
File path: utils/src/main/java/com/cloud/utils/ssh/SSHCmdHelper.java
##########
@@ -77,8 +80,47 @@ public String getStdErr() {
}
public static com.trilead.ssh2.Connection acquireAuthorizedConnection(String ip, int port, String username, String password) {
+ return acquireAuthorizedConnection(ip, 22, username, password, null);
+ }
+
+ public static boolean acquireAuthorizedConnectionWithPublicKey(final com.trilead.ssh2.Connection sshConnection, final String username, final String privateKey) {
+ if (StringUtils.isNotBlank(privateKey)) {
+ File privateKeyFile = null;
+ try {
+ privateKeyFile = File.createTempFile("cloudstack-host-", null);
Review comment:
> @weizhouapache This temp. hack may not be required as mgmt server saves the ssh private/pub keys at: `/var/lib/cloudstack/management/.ssh/id_rsa` on the mgmt server, why not just read/use that?
>
> In fact if this is saved/assumed, then we don't even need to read the private key from db and pass it here. Thoughts?
@rhtyd
I have considered it. but at the end I decided to use temp file so that the process will not rely on any file on management server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5684: (ccc2021 hackathon ) kvm: add hosts using cloudstack ssh private key
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#issuecomment-976750098
> @weizhouapache this is not in draft, is it ready for merge? (just making sure)
@DaanHoogland
it is ready for review (not merge).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5684: (ccc2021 hackathon ) kvm: add hosts using cloudstack ssh private key
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#discussion_r761912550
##########
File path: server/src/main/java/com/cloud/hypervisor/kvm/discoverer/LibvirtServerDiscoverer.java
##########
@@ -259,9 +259,17 @@ private void setupAgentSecurity(final Connection sshConnection, final String age
sshConnection = new Connection(agentIp, 22);
sshConnection.connect(null, 60000, 60000);
- if (!sshConnection.authenticateWithPassword(username, password)) {
- s_logger.debug("Failed to authenticate");
- throw new DiscoveredWithErrorException("Authentication error");
+
+ final String privateKey = _configDao.getValue("ssh.privatekey");
Review comment:
> if one authentication fails, try other may not be good.
@sureshanaparti ok. let's ask other guys.
@rhtyd @DaanHoogland what's your opinion ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5684: (ccc2021 hachathon ) kvm: add hosts using cloustack ssh private key
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#discussion_r748204933
##########
File path: utils/src/main/java/com/cloud/utils/ssh/SSHCmdHelper.java
##########
@@ -77,8 +80,47 @@ public String getStdErr() {
}
public static com.trilead.ssh2.Connection acquireAuthorizedConnection(String ip, int port, String username, String password) {
+ return acquireAuthorizedConnection(ip, 22, username, password, null);
+ }
+
+ public static boolean acquireAuthorizedConnectionWithPublicKey(final com.trilead.ssh2.Connection sshConnection, final String username, final String privateKey) {
+ if (StringUtils.isNotBlank(privateKey)) {
+ File privateKeyFile = null;
+ try {
+ privateKeyFile = File.createTempFile("cloudstack-host-", null);
+ FileWriter writer = new FileWriter(privateKeyFile.getAbsolutePath());
+ writer.write(privateKey);
+ writer.close();
+ } catch (IOException e) {
+ s_logger.warn("An exception occurred when create a tmp file and write private key to the tmp file");
+ return false;
+ }
+ try {
+ if (!sshConnection.authenticateWithPublicKey(username, privateKeyFile, null)) {
Review comment:
@rhtyd yes, I will use `char[]`, testing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5684: (ccc2021 hackathon ) kvm: add hosts using cloudstack ssh private key
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#discussion_r761837071
##########
File path: server/src/main/java/com/cloud/hypervisor/kvm/discoverer/LibvirtServerDiscoverer.java
##########
@@ -259,9 +259,17 @@ private void setupAgentSecurity(final Connection sshConnection, final String age
sshConnection = new Connection(agentIp, 22);
sshConnection.connect(null, 60000, 60000);
- if (!sshConnection.authenticateWithPassword(username, password)) {
- s_logger.debug("Failed to authenticate");
- throw new DiscoveredWithErrorException("Authentication error");
+
+ final String privateKey = _configDao.getValue("ssh.privatekey");
Review comment:
@sureshanaparti
isn't it better to support both ? hosts are still manageable if one of the authentication fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5684: (ccc2021 hachathon ) kvm: add hosts using cloustack ssh private key
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#issuecomment-967045752
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5684: (ccc2021 hackathon ) kvm: add hosts using cloudstack ssh private key
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#discussion_r761909986
##########
File path: server/src/main/java/com/cloud/hypervisor/kvm/discoverer/LibvirtServerDiscoverer.java
##########
@@ -259,9 +259,17 @@ private void setupAgentSecurity(final Connection sshConnection, final String age
sshConnection = new Connection(agentIp, 22);
sshConnection.connect(null, 60000, 60000);
- if (!sshConnection.authenticateWithPassword(username, password)) {
- s_logger.debug("Failed to authenticate");
- throw new DiscoveredWithErrorException("Authentication error");
+
+ final String privateKey = _configDao.getValue("ssh.privatekey");
Review comment:
>
if one authentication fails, try other may not be good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5684: (ccc2021 hackathon ) kvm: add hosts using cloudstack ssh private key
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#issuecomment-985862070
<b>Trillian test result (tid-2616)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30475 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5684-t2616-kvm-centos7.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5684: (ccc2021 hachathon ) kvm: add hosts using cloustack ssh private key
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#discussion_r748201184
##########
File path: utils/src/main/java/com/cloud/utils/ssh/SSHCmdHelper.java
##########
@@ -77,8 +80,47 @@ public String getStdErr() {
}
public static com.trilead.ssh2.Connection acquireAuthorizedConnection(String ip, int port, String username, String password) {
+ return acquireAuthorizedConnection(ip, 22, username, password, null);
+ }
+
+ public static boolean acquireAuthorizedConnectionWithPublicKey(final com.trilead.ssh2.Connection sshConnection, final String username, final String privateKey) {
+ if (StringUtils.isNotBlank(privateKey)) {
+ File privateKeyFile = null;
+ try {
+ privateKeyFile = File.createTempFile("cloudstack-host-", null);
+ FileWriter writer = new FileWriter(privateKeyFile.getAbsolutePath());
+ writer.write(privateKey);
+ writer.close();
Review comment:
@DaanHoogland
you are right. we could use `char[]` instead of `File` in the authentication. i will change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5684: (ccc2021 hachathon ) kvm: add hosts using cloustack ssh private key
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#discussion_r748199003
##########
File path: utils/src/main/java/com/cloud/utils/ssh/SSHCmdHelper.java
##########
@@ -77,8 +80,47 @@ public String getStdErr() {
}
public static com.trilead.ssh2.Connection acquireAuthorizedConnection(String ip, int port, String username, String password) {
+ return acquireAuthorizedConnection(ip, 22, username, password, null);
+ }
+
+ public static boolean acquireAuthorizedConnectionWithPublicKey(final com.trilead.ssh2.Connection sshConnection, final String username, final String privateKey) {
+ if (StringUtils.isNotBlank(privateKey)) {
+ File privateKeyFile = null;
+ try {
+ privateKeyFile = File.createTempFile("cloudstack-host-", null);
+ FileWriter writer = new FileWriter(privateKeyFile.getAbsolutePath());
+ writer.write(privateKey);
+ writer.close();
Review comment:
@DaanHoogland
the file is deleted in the `finally` block of next `try..catch..finally`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5684: (ccc2021 hachathon ) kvm: add hosts using cloustack ssh private key
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#discussion_r748212840
##########
File path: utils/src/main/java/com/cloud/utils/ssh/SSHCmdHelper.java
##########
@@ -77,8 +80,47 @@ public String getStdErr() {
}
public static com.trilead.ssh2.Connection acquireAuthorizedConnection(String ip, int port, String username, String password) {
+ return acquireAuthorizedConnection(ip, 22, username, password, null);
+ }
+
+ public static boolean acquireAuthorizedConnectionWithPublicKey(final com.trilead.ssh2.Connection sshConnection, final String username, final String privateKey) {
+ if (StringUtils.isNotBlank(privateKey)) {
+ File privateKeyFile = null;
+ try {
+ privateKeyFile = File.createTempFile("cloudstack-host-", null);
+ FileWriter writer = new FileWriter(privateKeyFile.getAbsolutePath());
+ writer.write(privateKey);
+ writer.close();
+ } catch (IOException e) {
+ s_logger.warn("An exception occurred when create a tmp file and write private key to the tmp file");
+ return false;
+ }
+ try {
+ if (!sshConnection.authenticateWithPublicKey(username, privateKeyFile, null)) {
Review comment:
@rhtyd @DaanHoogland
updated this PR to use `char[]` in server authentication. thanks for your review !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5684: (ccc2021 hachathon ) kvm: add hosts using cloustack ssh private key
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#issuecomment-967108465
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5684: (ccc2021 hackathon ) kvm: add hosts using cloudstack ssh private key
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#issuecomment-985429094
> @weizhouapache Does multiple kvm hosts in a cluster supports different authentication mechanism (few with passwords, and others with ssh key)? If so, is this info maintained in management server?
@sureshanaparti yes, if `host_details` table has record with name=`password` for the host, the host supports password authentication (as well as ssh key authentication).
if not, the host supports ssh key authentication only.
I think the main issue for now is, password authentication does not work sometimes, for example by ssh protocol, incorrect ssh settings, wrong password, password is changed. it should not be a problem/risk to ssh from mgmt server to hosts by both options, as they all use internal IPs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #5684: (ccc2021 hachathon ) kvm: add hosts using cloustack ssh private key
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#discussion_r748155446
##########
File path: utils/src/main/java/com/cloud/utils/ssh/SSHCmdHelper.java
##########
@@ -77,8 +80,47 @@ public String getStdErr() {
}
public static com.trilead.ssh2.Connection acquireAuthorizedConnection(String ip, int port, String username, String password) {
+ return acquireAuthorizedConnection(ip, 22, username, password, null);
+ }
+
+ public static boolean acquireAuthorizedConnectionWithPublicKey(final com.trilead.ssh2.Connection sshConnection, final String username, final String privateKey) {
+ if (StringUtils.isNotBlank(privateKey)) {
+ File privateKeyFile = null;
+ try {
+ privateKeyFile = File.createTempFile("cloudstack-host-", null);
Review comment:
@weizhouapache
This temp. hack may not be required as mgmt server saves the ssh private/pub keys at: `/var/lib/cloudstack/management/.ssh/id_rsa` on the mgmt server, why not just read/use that?
In fact if this is saved/assumed, then we don't even need to read the private key from db and pass it here. Thoughts?
##########
File path: ui/src/views/infra/HostAdd.vue
##########
@@ -94,9 +94,8 @@
<a-input :placeholder="placeholder.username" v-model="username"></a-input>
</div>
- <div class="form__item required-field" v-if="selectedClusterHyperVisorType !== 'VMware'">
- <div class="form__label"><span class="required">* </span>{{ $t('label.password') }}</div>
- <span class="required required-label">{{ $t('label.required') }}</span>
+ <div class="form__item" v-if="selectedClusterHyperVisorType !== 'VMware'">
+ <div class="form__label">{{ $t('label.password') }}</div>
Review comment:
Maybe be have it not required just for kvm? (for ex. required for xenserver?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #5684: (ccc2021 hachathon ) kvm: add hosts using cloustack ssh private key
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#discussion_r748153805
##########
File path: server/src/main/java/com/cloud/hypervisor/kvm/discoverer/LibvirtServerDiscoverer.java
##########
@@ -259,9 +259,14 @@ private void setupAgentSecurity(final Connection sshConnection, final String age
sshConnection = new Connection(agentIp, 22);
sshConnection.connect(null, 60000, 60000);
- if (!sshConnection.authenticateWithPassword(username, password)) {
- s_logger.debug("Failed to authenticate");
- throw new DiscoveredWithErrorException("Authentication error");
+
+ final String privateKey = _configDao.getValue("ssh.privatekey");
+ if (!SSHCmdHelper.acquireAuthorizedConnectionWithPublicKey(sshConnection, username, privateKey)) {
+ s_logger.error("Failed to authenticate with ssh key");
+ if (!sshConnection.authenticateWithPassword(username, password)) {
Review comment:
Nit - maybe do a check if password was even passed (empty?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5684: (ccc2021 hackathon ) kvm: add hosts using cloudstack ssh private key
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#issuecomment-985461705
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5684: (ccc2021 hachathon ) kvm: add hosts using cloustack ssh private key
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#issuecomment-967006228
Left some comments but nice hack @weizhouapache !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache edited a comment on pull request #5684: (ccc2021 hackathon ) kvm: add hosts using cloudstack ssh private key
Posted by GitBox <gi...@apache.org>.
weizhouapache edited a comment on pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#issuecomment-977738578
@DaanHoogland @rhtyd
made a UI change as per Rohit's comment.
<img src="https://user-images.githubusercontent.com/57355700/143220583-2ad5b88a-6e05-4587-913f-58303b9216d6.png" width="50%" height="50%">
<img src="https://user-images.githubusercontent.com/57355700/143220692-7103933a-68f9-4f1a-a264-ceb58267fc42.png" width="50%" height="50%">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5684: (ccc2021 hackathon ) kvm: add hosts using cloudstack ssh private key
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#issuecomment-985495842
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5684: (ccc2021 hackathon ) kvm: add hosts using cloudstack ssh private key
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#issuecomment-985453666
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5684: (ccc2021 hackathon ) kvm: add hosts using cloudstack ssh private key
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#issuecomment-985460300
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #5684: (ccc2021 hackathon ) kvm: add hosts using cloudstack ssh private key
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#discussion_r755026509
##########
File path: ui/src/views/infra/HostAdd.vue
##########
@@ -94,9 +94,8 @@
<a-input :placeholder="placeholder.username" v-model="username"></a-input>
</div>
- <div class="form__item required-field" v-if="selectedClusterHyperVisorType !== 'VMware'">
- <div class="form__label"><span class="required">* </span>{{ $t('label.password') }}</div>
- <span class="required required-label">{{ $t('label.required') }}</span>
+ <div class="form__item" v-if="selectedClusterHyperVisorType !== 'VMware'">
+ <div class="form__label">{{ $t('label.password') }}</div>
Review comment:
ping @weizhouapache when you've time - why not put explicit checks for example a radio/button or toggle to switch between password or ssh-key auth just for KVM (however for XenServer too this feature can be done).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5684: (ccc2021 hachathon ) kvm: add hosts using cloustack ssh private key
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#issuecomment-967006798
(of course your changes are closer to what maybe reviewed/tested merged so I'm being very thorough otherwise LGTM!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5684: (ccc2021 hackathon ) kvm: add hosts using cloudstack ssh private key
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#issuecomment-976629503
@weizhouapache this is not in draft, is it ready for merge? (just making sure)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5684: (ccc2021 hackathon ) kvm: add hosts using cloudstack ssh private key
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#issuecomment-977738578
@DaanHoogland @rhtyd
made a UI change as per Rohit's comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5684: (ccc2021 hackathon ) kvm: add hosts using cloudstack ssh private key
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#issuecomment-985424930
@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #5684: (ccc2021 hachathon ) kvm: add hosts using cloustack ssh private key
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#discussion_r748199130
##########
File path: utils/src/main/java/com/cloud/utils/ssh/SSHCmdHelper.java
##########
@@ -77,8 +80,47 @@ public String getStdErr() {
}
public static com.trilead.ssh2.Connection acquireAuthorizedConnection(String ip, int port, String username, String password) {
+ return acquireAuthorizedConnection(ip, 22, username, password, null);
+ }
+
+ public static boolean acquireAuthorizedConnectionWithPublicKey(final com.trilead.ssh2.Connection sshConnection, final String username, final String privateKey) {
+ if (StringUtils.isNotBlank(privateKey)) {
+ File privateKeyFile = null;
+ try {
+ privateKeyFile = File.createTempFile("cloudstack-host-", null);
Review comment:
In that case let's fix the mod bits of the file to be just read-only (0400)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5684: (ccc2021 hachathon ) kvm: add hosts using cloustack ssh private key
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#discussion_r748186973
##########
File path: utils/src/main/java/com/cloud/utils/ssh/SSHCmdHelper.java
##########
@@ -77,8 +80,47 @@ public String getStdErr() {
}
public static com.trilead.ssh2.Connection acquireAuthorizedConnection(String ip, int port, String username, String password) {
+ return acquireAuthorizedConnection(ip, 22, username, password, null);
+ }
+
+ public static boolean acquireAuthorizedConnectionWithPublicKey(final com.trilead.ssh2.Connection sshConnection, final String username, final String privateKey) {
+ if (StringUtils.isNotBlank(privateKey)) {
+ File privateKeyFile = null;
+ try {
+ privateKeyFile = File.createTempFile("cloudstack-host-", null);
+ FileWriter writer = new FileWriter(privateKeyFile.getAbsolutePath());
+ writer.write(privateKey);
+ writer.close();
Review comment:
this is a bit of a security risk, it seems. The file is created in /tmp and never deleted (automatically if the JVM shuts down, but what if it crashes?). We may want a way to pass the key to the `sshConnection` as string instead of a file ref.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5684: (ccc2021 hackathon ) kvm: add hosts using cloudstack ssh private key
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#discussion_r755946651
##########
File path: server/src/main/java/com/cloud/hypervisor/kvm/discoverer/LibvirtServerDiscoverer.java
##########
@@ -259,9 +259,17 @@ private void setupAgentSecurity(final Connection sshConnection, final String age
sshConnection = new Connection(agentIp, 22);
sshConnection.connect(null, 60000, 60000);
- if (!sshConnection.authenticateWithPassword(username, password)) {
- s_logger.debug("Failed to authenticate");
- throw new DiscoveredWithErrorException("Authentication error");
+
+ final String privateKey = _configDao.getValue("ssh.privatekey");
Review comment:
@weizhouapache I think, it is better to try with ssh key or password (based on the authentication mode), not with other when one of it fails. You can determine authentication mode, either from the user input or may be from password/privatekey config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5684: (ccc2021 hachathon ) kvm: add hosts using cloustack ssh private key
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#issuecomment-967017260
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5684: (ccc2021 hackathon ) kvm: add hosts using cloudstack ssh private key
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#discussion_r755059688
##########
File path: ui/src/views/infra/HostAdd.vue
##########
@@ -94,9 +94,8 @@
<a-input :placeholder="placeholder.username" v-model="username"></a-input>
</div>
- <div class="form__item required-field" v-if="selectedClusterHyperVisorType !== 'VMware'">
- <div class="form__label"><span class="required">* </span>{{ $t('label.password') }}</div>
- <span class="required required-label">{{ $t('label.required') }}</span>
+ <div class="form__item" v-if="selectedClusterHyperVisorType !== 'VMware'">
+ <div class="form__label">{{ $t('label.password') }}</div>
Review comment:
@rhtyd
good idea. will make the UI change.
let's support kvm at first, then xenserver (this is not needed for vmware).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5684: (ccc2021 hackathon ) kvm: add hosts using cloudstack ssh private key
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#issuecomment-985401903
LGTM, @weizhouapache is this ready for testing ? cc @borisstoyanov @vladimirpetrov
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5684: (ccc2021 hackathon ) kvm: add hosts using cloudstack ssh private key
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#issuecomment-985454942
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud merged pull request #5684: (ccc2021 hackathon ) kvm: add hosts using cloudstack ssh private key
Posted by GitBox <gi...@apache.org>.
rohityadavcloud merged pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5684: (ccc2021 hackathon ) kvm: add hosts using cloudstack ssh private key
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#issuecomment-977776358
@weizhouapache Does multiple kvm hosts in a cluster supports different authentication mechanism (few with passwords, and others with ssh key)? If so, is this info maintained in management server?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache edited a comment on pull request #5684: (ccc2021 hackathon ) kvm: add hosts using cloudstack ssh private key
Posted by GitBox <gi...@apache.org>.
weizhouapache edited a comment on pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#issuecomment-977738578
@DaanHoogland @rhtyd
made a UI change as per Rohit's comment.
<img src="https://user-images.githubusercontent.com/57355700/143220583-2ad5b88a-6e05-4587-913f-58303b9216d6.png" width="50%" height="50%">
<img src="https://user-images.githubusercontent.com/57355700/143220692-7103933a-68f9-4f1a-a264-ceb58267fc42.png" width="50%" height="50%">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5684: (ccc2021 hackathon ) kvm: add hosts using cloudstack ssh private key
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#issuecomment-985402480
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5684: (ccc2021 hachathon ) kvm: add hosts using cloustack ssh private key
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#issuecomment-967109166
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5684: (ccc2021 hachathon ) kvm: add hosts using cloustack ssh private key
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#issuecomment-966987939
@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5684: (ccc2021 hachathon ) kvm: add hosts using cloustack ssh private key
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#issuecomment-966987534
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #5684: (ccc2021 hachathon ) kvm: add hosts using cloustack ssh private key
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#discussion_r748198306
##########
File path: utils/src/main/java/com/cloud/utils/ssh/SSHCmdHelper.java
##########
@@ -77,8 +80,47 @@ public String getStdErr() {
}
public static com.trilead.ssh2.Connection acquireAuthorizedConnection(String ip, int port, String username, String password) {
+ return acquireAuthorizedConnection(ip, 22, username, password, null);
+ }
+
+ public static boolean acquireAuthorizedConnectionWithPublicKey(final com.trilead.ssh2.Connection sshConnection, final String username, final String privateKey) {
+ if (StringUtils.isNotBlank(privateKey)) {
+ File privateKeyFile = null;
+ try {
+ privateKeyFile = File.createTempFile("cloudstack-host-", null);
+ FileWriter writer = new FileWriter(privateKeyFile.getAbsolutePath());
+ writer.write(privateKey);
+ writer.close();
+ } catch (IOException e) {
+ s_logger.warn("An exception occurred when create a tmp file and write private key to the tmp file");
+ return false;
+ }
+ try {
+ if (!sshConnection.authenticateWithPublicKey(username, privateKeyFile, null)) {
Review comment:
@weizhouapache can we pass the privatekey content to this method (or similar available methods)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5684: (ccc2021 hackathon ) kvm: add hosts using cloudstack ssh private key
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#issuecomment-985423755
> LGTM, @weizhouapache is this ready for testing ? cc @borisstoyanov @vladimirpetrov @blueorangutan package
@rhtyd yes, it is ready for review and testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5684: (ccc2021 hackathon ) kvm: add hosts using cloudstack ssh private key
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#issuecomment-985495978
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5684: (ccc2021 hackathon ) kvm: add hosts using cloudstack ssh private key
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#issuecomment-985452102
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5684: (ccc2021 hackathon ) kvm: add hosts using cloudstack ssh private key
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5684:
URL: https://github.com/apache/cloudstack/pull/5684#issuecomment-985457975
<b>Trillian Build Failed (tid-2615)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org