You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "David Reiss (JIRA)" <ji...@apache.org> on 2008/12/02 03:09:44 UTC

[jira] Commented: (THRIFT-138) Generated Thrift structs should have a deep-copy constructor

    [ https://issues.apache.org/jira/browse/THRIFT-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652234#action_12652234 ] 

David Reiss commented on THRIFT-138:
------------------------------------

Hey guys.  I just realized that this doesn't work properly for binary fields.  Any chance you could implement that?

> Generated Thrift structs should have a deep-copy constructor
> ------------------------------------------------------------
>
>                 Key: THRIFT-138
>                 URL: https://issues.apache.org/jira/browse/THRIFT-138
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Compiler (Java)
>            Reporter: Bryan Duxbury
>            Assignee: Piotr Kozikowski
>            Priority: Minor
>         Attachments: thrift-138-v2.patch, thrift-138-v3.patch, thrift-138-v4.patch, thrift-138-v5.patch, thrift-138-v6.patch, thrift-138-v7-test.patch, thrift-138-v7.patch, thrift-138-v8.patch, thrift-138.patch
>
>
> It'd be nice to be able to make a copy of a Thrift object by passing it as an argument to the constructor of the same object. Right now, we have to use a serialize/deserialize approach to making a deep object copy, and that seems really inefficient.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.