DO NOT REPLY [Bug 24924] New: - saveBody internal member is held in memory

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24924>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24924

saveBody internal member is held in memory

           Summary: saveBody internal member is held in memory
           Product: Struts
           Version: 1.1 Beta 2
          Platform: All
               URL: http://cvs.apache.org/viewcvs/jakarta-
                    struts/src/share/org/apache/struts/taglib/html/SelectTag
                    .java.diff?r1=1.2&r2=1.3
        OS/Version: All
            Status: NEW
          Severity: Minor
          Priority: Other
         Component: Custom Tags
        AssignedTo: struts-dev@jakarta.apache.org
        ReportedBy: home@joshuajdmartin.com


Using an internal member (versus the bodyContent) makes subclassing much more 
difficult.  This internal member is held in memory, and though it's in the 
release() method, that's not going to be nullified until GC time.  The 
bodyContent is also in memory, but since it's a known member, it's easier to 
wipe it out if needed.  Suggested fix: simply remove this and use the 
bodyContent directly in the doEndTag() method.  The doAfterBody() method can 
be eliminated.  I'd make the change, but I'm a newcomer to Struts, and this 
value may be doing things that I'm not aware of - please reply if I'm off base.

---------------------------------------------------------------------
To unsubscribe, e-mail: struts-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: struts-dev-help@jakarta.apache.org