You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "xiangfu0 (via GitHub)" <gi...@apache.org> on 2026/01/13 11:36:06 UTC
[PR] Add header links next to cluster name [pinot]
xiangfu0 opened a new pull request, #17499:
URL: https://github.com/apache/pinot/pull/17499
Add pinot site and docs into UI page right upper corner for quick links
<img width="1921" height="640" alt="image" src="https://github.com/user-attachments/assets/75b8c710-640f-43c0-adb6-eee91473a63b" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [ui] Add header links next to cluster name [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 merged PR #17499:
URL: https://github.com/apache/pinot/pull/17499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Add header links next to cluster name [pinot]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #17499:
URL: https://github.com/apache/pinot/pull/17499#discussion_r2686315185
##########
pinot-controller/src/main/resources/app/components/Header.tsx:
##########
@@ -33,6 +33,51 @@ type Props = {
};
const useStyles = makeStyles((theme) => ({
+ clusterContainer: {
+ display: 'flex',
+ alignItems: 'center',
+ marginRight: theme.spacing(2),
+ },
+ clusterBox: {
+ textAlign: 'center',
+ margin: '11.5px 0',
+ paddingLeft: theme.spacing(2),
+ borderLeft: '1px solid rgba(255,255,255,0.5)',
+ },
+ linkGroup: {
+ display: 'flex',
+ alignItems: 'center',
+ gap: theme.spacing(1),
+ fontSize: '0.85rem',
+ paddingLeft: theme.spacing(1.5),
+ whiteSpace: 'nowrap',
+ borderLeft: '1px solid rgba(255,255,255,0.5)',
+ },
+ linkColumn: {
+ display: 'flex',
+ flexDirection: 'column',
+ height: theme.spacing(5),
+ minWidth: theme.spacing(9),
+ },
+ linkItem: {
+ flex: 1,
+ display: 'flex',
+ alignItems: 'center',
+ justifyContent: 'center',
+ padding: theme.spacing(0, 1),
+ },
+ linkItemTop: {
+ borderBottom: '1px solid rgba(255, 255, 255, 0.2)',
+ },
+ link: {
+ color: 'rgba(255, 255, 255, 0.9)',
+ textDecoration: 'none',
+ fontWeight: 700,
+ '&:hover': {
+ color: '#fff',
+ textDecoration: 'underline',
+ },
+ },
breadcrumbRoot:{
Review Comment:
Missing space after property name. Should be `breadcrumbRoot: {` for consistency with TypeScript/JavaScript style conventions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Add header links next to cluster name [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #17499:
URL: https://github.com/apache/pinot/pull/17499#issuecomment-3744030228
### :x: 2 Tests Failed:
| Tests completed | Failed | Passed | Skipped |
|---|---|---|---|
| 6112 | 2 | 6110 | 0 |
<details><summary>View the top 2 failed test(s) by shortest run time</summary>
> <pre><code class="language-python">org.apache.pinot.controller.helix.core.minion.PinotTaskManagerDistributedLockingTest::testForceReleaseLockDuringTaskExecution</code></pre>
> <details><summary>Stack Traces | 18.4s run time</summary>
>
> > <pre><code class="language-python">Both createTask calls should have generated tasks expected [2] but found [3]</code></pre>
>
> </details>
> <pre><code class="language-python">org.apache.pinot.controller.helix.core.minion.PinotTaskManagerDistributedLockingTest::testForceReleaseLockDuringTaskExecution</code></pre>
> <details><summary>Stack Traces | 20.6s run time</summary>
>
> > <pre><code class="language-python">Both createTask calls should have generated tasks expected [2] but found [3]</code></pre>
>
> </details>
</details>
To view more test analytics, go to the [Test Analytics Dashboard](https://app.codecov.io/gh/apache/pinot/tests/xiangfu0%3Aui%2Fheader-links)
<sub>📋 Got 3 mins? [Take this short survey](https://forms.gle/22i53Qa1CySZjA6c7) to help us improve Test Analytics.</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org