You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pluto-dev@portals.apache.org by "Ajay Panagariya (JIRA)" <ji...@apache.org> on 2007/07/19 05:16:04 UTC

[jira] Created: (PLUTO-396) Parameters containing URIs with query portion are passed incorrectly

Parameters containing URIs with query portion are passed incorrectly
--------------------------------------------------------------------

                 Key: PLUTO-396
                 URL: https://issues.apache.org/jira/browse/PLUTO-396
             Project: Pluto
          Issue Type: Bug
          Components: portal driver
    Affects Versions: 1.2.0
            Reporter: Ajay Panagariya
             Fix For: 1.2.0


Some URL's are of the form

(a)   http://www.example.com/test?item=pluto.apache.com

others are of the form

(b)   http://www.example.com/test?item=pluto.apache.com/wiki?id=1234

In (b), the special characters get encoded as %F3's, etc. When it gets to processAction method in the portlet, the URI of concern (the 'item' parameter in this case) looks fine. By this parameters gets to the doView, everything after the '?' is lost. The patch I am including properly encodes the '?' such that the '?' is not misinterpreted. I have also added comments to the section of code pertaining to this, so that if there are other special characters that need to be handled in the future it is clear where these should be added.

-Ajay Panagariya

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PLUTO-396) Parameters containing URIs with query portion are passed incorrectly

Posted by "Ajay Panagariya (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PLUTO-396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ajay Panagariya updated PLUTO-396:
----------------------------------

    Attachment:     (was: pluto-396.patch)

> Parameters containing URIs with query portion are passed incorrectly
> --------------------------------------------------------------------
>
>                 Key: PLUTO-396
>                 URL: https://issues.apache.org/jira/browse/PLUTO-396
>             Project: Pluto
>          Issue Type: Bug
>          Components: portal driver
>    Affects Versions: 1.2.0
>            Reporter: Ajay Panagariya
>             Fix For: 1.2.0
>
>         Attachments: pluto-396.patch
>
>
> Some URL's are of the form
> (a)   http://www.example.com/test?item=pluto.apache.com
> others are of the form
> (b)   http://www.example.com/test?item=pluto.apache.com/wiki?id=1234
> In (b), the special characters get encoded as %F3's, etc. When it gets to processAction method in the portlet, the URI of concern (the 'item' parameter in this case) looks fine. By this parameters gets to the doView, everything after the '?' is lost. The patch I am including properly encodes the '?' such that the '?' is not misinterpreted. I have also added comments to the section of code pertaining to this, so that if there are other special characters that need to be handled in the future it is clear where these should be added.
> -Ajay Panagariya

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PLUTO-396) Parameters containing URIs with query portion are passed incorrectly

Posted by "Ajay Panagariya (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PLUTO-396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ajay Panagariya updated PLUTO-396:
----------------------------------

    Attachment: pluto-396.patch

Here is a new patch with two more offending characters that cause parameters to be passed incorrectly (percent % and backslash \). Both of these characters, like the question mark, are misinterpreted without some sort of special encoding.

-Ajay Panagariya

> Parameters containing URIs with query portion are passed incorrectly
> --------------------------------------------------------------------
>
>                 Key: PLUTO-396
>                 URL: https://issues.apache.org/jira/browse/PLUTO-396
>             Project: Pluto
>          Issue Type: Bug
>          Components: portal driver
>    Affects Versions: 1.2.0
>            Reporter: Ajay Panagariya
>             Fix For: 1.2.0
>
>         Attachments: pluto-396.patch, pluto-396.patch
>
>
> Some URL's are of the form
> (a)   http://www.example.com/test?item=pluto.apache.com
> others are of the form
> (b)   http://www.example.com/test?item=pluto.apache.com/wiki?id=1234
> In (b), the special characters get encoded as %F3's, etc. When it gets to processAction method in the portlet, the URI of concern (the 'item' parameter in this case) looks fine. By this parameters gets to the doView, everything after the '?' is lost. The patch I am including properly encodes the '?' such that the '?' is not misinterpreted. I have also added comments to the section of code pertaining to this, so that if there are other special characters that need to be handled in the future it is clear where these should be added.
> -Ajay Panagariya

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (PLUTO-396) Parameters containing URIs with query portion are passed incorrectly

Posted by "Craig Doremus (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PLUTO-396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Craig Doremus resolved PLUTO-396.
---------------------------------

    Resolution: Fixed
      Assignee: Craig Doremus

Applied in SVN revision 558892. Thank you Ajay!

> Parameters containing URIs with query portion are passed incorrectly
> --------------------------------------------------------------------
>
>                 Key: PLUTO-396
>                 URL: https://issues.apache.org/jira/browse/PLUTO-396
>             Project: Pluto
>          Issue Type: Bug
>          Components: portal driver
>    Affects Versions: 1.2.0
>            Reporter: Ajay Panagariya
>            Assignee: Craig Doremus
>             Fix For: 1.2.0
>
>         Attachments: pluto-396.patch
>
>
> Some URL's are of the form
> (a)   http://www.example.com/test?item=pluto.apache.com
> others are of the form
> (b)   http://www.example.com/test?item=pluto.apache.com/wiki?id=1234
> In (b), the special characters get encoded as %F3's, etc. When it gets to processAction method in the portlet, the URI of concern (the 'item' parameter in this case) looks fine. By this parameters gets to the doView, everything after the '?' is lost. The patch I am including properly encodes the '?' such that the '?' is not misinterpreted. I have also added comments to the section of code pertaining to this, so that if there are other special characters that need to be handled in the future it is clear where these should be added.
> -Ajay Panagariya

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (PLUTO-396) Parameters containing URIs with query portion are passed incorrectly

Posted by "Ajay Panagariya (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PLUTO-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12513797 ] 

Ajay Panagariya edited comment on PLUTO-396 at 7/18/07 8:25 PM:
----------------------------------------------------------------

Here's the patch that properly encodes "?" characters to prevent URI's with queries from being misinterpreted.

-Ajay Panagariya


 was:
Here's the patch that properly encoded "?" characters to prevent URI's with queries from being misinterpreted.

-Ajay Panagariya

> Parameters containing URIs with query portion are passed incorrectly
> --------------------------------------------------------------------
>
>                 Key: PLUTO-396
>                 URL: https://issues.apache.org/jira/browse/PLUTO-396
>             Project: Pluto
>          Issue Type: Bug
>          Components: portal driver
>    Affects Versions: 1.2.0
>            Reporter: Ajay Panagariya
>             Fix For: 1.2.0
>
>         Attachments: pluto-396.patch
>
>
> Some URL's are of the form
> (a)   http://www.example.com/test?item=pluto.apache.com
> others are of the form
> (b)   http://www.example.com/test?item=pluto.apache.com/wiki?id=1234
> In (b), the special characters get encoded as %F3's, etc. When it gets to processAction method in the portlet, the URI of concern (the 'item' parameter in this case) looks fine. By this parameters gets to the doView, everything after the '?' is lost. The patch I am including properly encodes the '?' such that the '?' is not misinterpreted. I have also added comments to the section of code pertaining to this, so that if there are other special characters that need to be handled in the future it is clear where these should be added.
> -Ajay Panagariya

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (PLUTO-396) Parameters containing URIs with query portion are passed incorrectly

Posted by "Ajay Panagariya (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PLUTO-396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ajay Panagariya updated PLUTO-396:
----------------------------------

    Attachment: pluto-396.patch

Here's the patch that properly encoded "?" characters to prevent URI's with queries from being misinterpreted.

-Ajay Panagariya

> Parameters containing URIs with query portion are passed incorrectly
> --------------------------------------------------------------------
>
>                 Key: PLUTO-396
>                 URL: https://issues.apache.org/jira/browse/PLUTO-396
>             Project: Pluto
>          Issue Type: Bug
>          Components: portal driver
>    Affects Versions: 1.2.0
>            Reporter: Ajay Panagariya
>             Fix For: 1.2.0
>
>         Attachments: pluto-396.patch
>
>
> Some URL's are of the form
> (a)   http://www.example.com/test?item=pluto.apache.com
> others are of the form
> (b)   http://www.example.com/test?item=pluto.apache.com/wiki?id=1234
> In (b), the special characters get encoded as %F3's, etc. When it gets to processAction method in the portlet, the URI of concern (the 'item' parameter in this case) looks fine. By this parameters gets to the doView, everything after the '?' is lost. The patch I am including properly encodes the '?' such that the '?' is not misinterpreted. I have also added comments to the section of code pertaining to this, so that if there are other special characters that need to be handled in the future it is clear where these should be added.
> -Ajay Panagariya

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.