You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by karlhigley <gi...@git.apache.org> on 2014/07/05 20:39:23 UTC

[GitHub] spark pull request: SPARK-1216. Add a OneHotEncoder for handling c...

Github user karlhigley commented on the pull request:

    https://github.com/apache/spark/pull/304#issuecomment-48093398
  
    This looked useful, so I tried it out.  It works as expected so long as the feature array is an `Array[Any]`.    If the features are all categorical, then the feature array could be an `Array[String]`.  In that case, `encodeVec` will instantiate an `Array[String]` for `outVec`, which results in an exception on line 125, because `Array[String]` won't accept an integer value.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---