You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/07/12 07:29:46 UTC
[GitHub] [druid] jerryleooo opened a new pull request #11433: Fix typo in the ingestion spec sample
jerryleooo opened a new pull request #11433:
URL: https://github.com/apache/druid/pull/11433
Fixes #11432
### Description
Fix typo in the ingestion spec sample
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s merged pull request #11433: Fix typo in ingestion spec sample
Posted by GitBox <gi...@apache.org>.
suneet-s merged pull request #11433:
URL: https://github.com/apache/druid/pull/11433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on pull request #11433: Fix typo in ingestion spec sample
Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #11433:
URL: https://github.com/apache/druid/pull/11433#issuecomment-883055113
Thanks for the contribution @jerryleooo !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] FrankChen021 commented on pull request #11433: Fix typo in ingestion spec sample
Posted by GitBox <gi...@apache.org>.
FrankChen021 commented on pull request #11433:
URL: https://github.com/apache/druid/pull/11433#issuecomment-878166009
Thanks for your contribution. I see there are multiple occurrences of this bad typo, kindly search and fix all of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jerryleooo commented on a change in pull request #11433: Fix typo in ingestion spec sample
Posted by GitBox <gi...@apache.org>.
jerryleooo commented on a change in pull request #11433:
URL: https://github.com/apache/druid/pull/11433#discussion_r668615077
##########
File path: docs/ingestion/index.md
##########
@@ -309,8 +309,8 @@ Example ingestion spec for task type `index_parallel` (native batch):
},
"dimensionsSpec": {
"dimensions": [
- { "type": "string", "page" },
- { "type": "string", "language" },
+ { "type": "string", "name": "page" },
Review comment:
Thanks @clintropolis , I have fixed them all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s merged pull request #11433: Fix typo in ingestion spec sample
Posted by GitBox <gi...@apache.org>.
suneet-s merged pull request #11433:
URL: https://github.com/apache/druid/pull/11433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s merged pull request #11433: Fix typo in ingestion spec sample
Posted by GitBox <gi...@apache.org>.
suneet-s merged pull request #11433:
URL: https://github.com/apache/druid/pull/11433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on pull request #11433: Fix typo in ingestion spec sample
Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #11433:
URL: https://github.com/apache/druid/pull/11433#issuecomment-883055113
Thanks for the contribution @jerryleooo !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on a change in pull request #11433: Fix typo in ingestion spec sample
Posted by GitBox <gi...@apache.org>.
clintropolis commented on a change in pull request #11433:
URL: https://github.com/apache/druid/pull/11433#discussion_r668564032
##########
File path: docs/ingestion/index.md
##########
@@ -309,8 +309,8 @@ Example ingestion spec for task type `index_parallel` (native batch):
},
"dimensionsSpec": {
"dimensions": [
- { "type": "string", "page" },
- { "type": "string", "language" },
+ { "type": "string", "name": "page" },
Review comment:
lines 385-386, 663-664 also have this same mistake
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] FrankChen021 commented on a change in pull request #11433: Fix typo in ingestion spec sample
Posted by GitBox <gi...@apache.org>.
FrankChen021 commented on a change in pull request #11433:
URL: https://github.com/apache/druid/pull/11433#discussion_r667812561
##########
File path: docs/ingestion/index.md
##########
@@ -309,8 +309,8 @@ Example ingestion spec for task type `index_parallel` (native batch):
},
"dimensionsSpec": {
"dimensions": [
- { "type": "string", "page" },
- { "type": "string", "language" },
+ { "type": "string", "name": "page" },
Review comment:
I think we could use "page" directly instead of an json object. See Line 448 and 472 of this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on pull request #11433: Fix typo in ingestion spec sample
Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #11433:
URL: https://github.com/apache/druid/pull/11433#issuecomment-883055113
Thanks for the contribution @jerryleooo !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org