You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/14 07:10:28 UTC
[GitHub] [skywalking-java] lujiajing1126 opened a new pull request #25: Chore: Add benchmark and improve docs for exception-ignore plugin
lujiajing1126 opened a new pull request #25:
URL: https://github.com/apache/skywalking-java/pull/25
Signed-off-by: Megrez Lu <lu...@gmail.com>
### Add details about the performance footprint of `exception-ignore` plugin
- [x] Add a benchmark for the improvement. Not applicable.
- [x] The benchmark result.
```text
/**
* # JMH version: 1.33
* # VM version: JDK 1.8.0_292, OpenJDK 64-Bit Server VM, 25.292-b10
* # VM invoker: /Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home/jre/bin/java
* # VM options: -javaagent:/Applications/IntelliJ IDEA.app/Contents/lib/idea_rt.jar=54972:/Applications/IntelliJ IDEA.app/Contents/bin -Dfile.encoding=UTF-8
* # Blackhole mode: full + dont-inline hint (default, use -Djmh.blackhole.autoDetect=true to auto-detect)
* # Warmup: 5 iterations, 10 s each
* # Measurement: 5 iterations, 10 s each
* # Timeout: 10 min per iteration
* # Threads: 1 thread, will synchronize iterations
* # Benchmark mode: Average time, time/op
* <p/>
* Benchmark Mode Cnt Score Error Units
* HierarchyMatchExceptionBenchmark.depthOneBenchmark avgt 25 31.050 ± 0.731 ns/op
* HierarchyMatchExceptionBenchmark.depthTwoBenchmark avgt 25 64.918 ± 2.537 ns/op
* HierarchyMatchExceptionBenchmark.depthThreeBenchmark avgt 25 89.645 ± 2.556 ns/op
*/
```
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng merged pull request #25: Chore: Add benchmark and improve docs for exception-ignore plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #25:
URL: https://github.com/apache/skywalking-java/pull/25
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #25: Chore: Add benchmark and improve docs for exception-ignore plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #25:
URL: https://github.com/apache/skywalking-java/pull/25#issuecomment-918876521
Please update `changes.md` in the root.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] lujiajing1126 commented on pull request #25: Chore: Add benchmark and improve docs for exception-ignore plugin
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on pull request #25:
URL: https://github.com/apache/skywalking-java/pull/25#issuecomment-918881005
> Please update `changes.md` in the root.
Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #25: Chore: Add benchmark and improve docs for exception-ignore plugin
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #25:
URL: https://github.com/apache/skywalking-java/pull/25#discussion_r707978591
##########
File path: docs/en/setup/service-agent/java-agent/How-to-tolerate-exceptions.md
##########
@@ -107,8 +107,15 @@ If an exception has the `@IgnoredException` annotation, the exception wouldn't b
`org.apache.skywalking.apm.agent.core.context.status.TestAnnotatedException` | false |
## Recursive check
-Due to the wrapper nature of Java exceptions, sometimes users need recursive checking. Skywalking also supports it. Typically, we don't recommend setting this more than 10, which could cause a performance issue. Negative value and 0 would be ignored, which means all exceptions would make the span tagged in error status.
+Due to the wrapper nature of Java exceptions, sometimes users need recursive checking. Skywalking also supports it.
```
- statuscheck.max_recursive_depth=${SW_STATUSCHECK_MAX_RECURSIVE_DEPTH:1}
+statuscheck.max_recursive_depth=${SW_STATUSCHECK_MAX_RECURSIVE_DEPTH:1}
```
+
+According to the benchmark result, the exception check time is nearly proportional to the recursive depth being set.
Review comment:
Please attach your benchmark result here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] lujiajing1126 commented on a change in pull request #25: Chore: Add benchmark and improve docs for exception-ignore plugin
Posted by GitBox <gi...@apache.org>.
lujiajing1126 commented on a change in pull request #25:
URL: https://github.com/apache/skywalking-java/pull/25#discussion_r707983236
##########
File path: docs/en/setup/service-agent/java-agent/How-to-tolerate-exceptions.md
##########
@@ -107,8 +107,15 @@ If an exception has the `@IgnoredException` annotation, the exception wouldn't b
`org.apache.skywalking.apm.agent.core.context.status.TestAnnotatedException` | false |
## Recursive check
-Due to the wrapper nature of Java exceptions, sometimes users need recursive checking. Skywalking also supports it. Typically, we don't recommend setting this more than 10, which could cause a performance issue. Negative value and 0 would be ignored, which means all exceptions would make the span tagged in error status.
+Due to the wrapper nature of Java exceptions, sometimes users need recursive checking. Skywalking also supports it.
```
- statuscheck.max_recursive_depth=${SW_STATUSCHECK_MAX_RECURSIVE_DEPTH:1}
+statuscheck.max_recursive_depth=${SW_STATUSCHECK_MAX_RECURSIVE_DEPTH:1}
```
+
+According to the benchmark result, the exception check time is nearly proportional to the recursive depth being set.
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org