You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/05/17 00:15:09 UTC

[GitHub] [tvm] adstraw commented on a diff in pull request #11319: [Hexagon] Add unit tests for Hexagon Device API

adstraw commented on code in PR #11319:
URL: https://github.com/apache/tvm/pull/11319#discussion_r874252860


##########
docker/Dockerfile.ci_hexagon:
##########
@@ -62,8 +62,7 @@ ENV HEXAGON_SDK_ROOT "/opt/qualcomm/hexagon_sdk"
 ENV CLANG_LLVM_HOME /opt/clang-llvm
 ENV LD_LIBRARY_PATH $LD_LIBRARY_PATH:/opt/clang-llvm/lib
 ENV PATH /opt/clang-llvm/bin:$PATH
-ENV HEXAGON_TOOLCHAIN "${HEXAGON_SDK_ROOT}/tools/HEXAGON_Tools/8.5.08/Tools"
-ENV HEXAGON_GTEST "${HEXAGON_SDK_ROOT}/utils/googletest/gtest"

Review Comment:
   Decided to remove all reference to `HEXAGON_GTEST` environment variable.  Now using just the `USE_HEXAGON_GTEST` cmake flag. 
   
   You said "not using SDK_PATH" anymore, did you mean "not using SDK_ROOT"?  I am not sure how the `HEXAGON_TOOLCHAIN` env variable ended up using "ROOT" instead of "PATH".  Might have been a copy/paste error on my part?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org