[GitHub] [systemds] Baunsgaard commented on pull request #1525: [SYSTEMDS-3280] WIP: Add homomorphic encryption to Federated Parameter Server

[GitBox <gi...@apache.org>]

Baunsgaard commented on pull request #1525:
URL: https://github.com/apache/systemds/pull/1525#issuecomment-1036385767


   
   
   
   > **Just to give an update on the merging of this PR:** I have been trying for the last couple of days to set up SEAL in the Docker test image so that the HE tests can be run by GitHub actions. This is still unsuccessful. It seems like I can set up SEAL sucessfully in the Docker container, but something goes wrong with the linking so when I run the tests, SystemDS cannot use SEAL and therefore the tests fail. I don't know what to do about this yet, but I am planning to disable the HE tests for this PR and merge it with the tests disabled and then add the Docker details in a later PR where the tests are activated.
   > 
   > **An unrelated comment:** It looks like the licenses are still missing from this PR. We need a license in the top of every code file added. See [this link](https://github.com/apache/systemds/blob/main/CONTRIBUTING.md) under the headline "License" how the licenses need to look for the different programming languages.
   
   I would suggest that you open a new PR where you modify the Docker container.
   Then once we are happy with the changes we merge it and let git update the container.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org