You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/02/26 17:57:53 UTC

[GitHub] [activemq] jbonofre opened a new pull request #477: [AMQ-7131] Add connectionTimeout to avoid starvation

jbonofre opened a new pull request #477: [AMQ-7131] Add connectionTimeout to avoid starvation
URL: https://github.com/apache/activemq/pull/477
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq] jbonofre commented on issue #477: [AMQ-7131] Add connectionTimeout to avoid starvation

Posted by GitBox <gi...@apache.org>.
jbonofre commented on issue #477: [AMQ-7131] Add connectionTimeout to avoid starvation
URL: https://github.com/apache/activemq/pull/477#issuecomment-591563235
 
 
   Ah, I guess you mean that `jms-pool` should be in a shared repository to be used by activemq and artemis, right ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq] michaelandrepearce commented on issue #477: [AMQ-7131] Add connectionTimeout to avoid starvation

Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on issue #477: [AMQ-7131] Add connectionTimeout to avoid starvation
URL: https://github.com/apache/activemq/pull/477#issuecomment-591600804
 
 
   Yup exactly 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq] jbonofre merged pull request #477: [AMQ-7131] Add connectionTimeout to avoid starvation

Posted by GitBox <gi...@apache.org>.
jbonofre merged pull request #477: [AMQ-7131] Add connectionTimeout to avoid starvation
URL: https://github.com/apache/activemq/pull/477
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq] michaelandrepearce commented on issue #477: [AMQ-7131] Add connectionTimeout to avoid starvation

Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on issue #477: [AMQ-7131] Add connectionTimeout to avoid starvation
URL: https://github.com/apache/activemq/pull/477#issuecomment-591562245
 
 
   @jbonofre is it worth pulling this library into its own repo so it can have its own lifecycle also will avoid having to dupe it all in artemis 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq] jbonofre commented on issue #477: [AMQ-7131] Add connectionTimeout to avoid starvation

Posted by GitBox <gi...@apache.org>.
jbonofre commented on issue #477: [AMQ-7131] Add connectionTimeout to avoid starvation
URL: https://github.com/apache/activemq/pull/477#issuecomment-591953763
 
 
   @michaelandrepearce you are right: if it's used in both ActiveMQ and Artemis, it makes sense to share it. The question is where ? Do we have to create a new `activemq-share` repo ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq] jbonofre commented on issue #477: [AMQ-7131] Add connectionTimeout to avoid starvation

Posted by GitBox <gi...@apache.org>.
jbonofre commented on issue #477: [AMQ-7131] Add connectionTimeout to avoid starvation
URL: https://github.com/apache/activemq/pull/477#issuecomment-591562910
 
 
   @michaelandrepearce I'm not sure I follow you. Here, we fixed in `activemq-jms-pool`, you mean to "reuse" artemis connection pool ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [activemq] michaelandrepearce edited a comment on issue #477: [AMQ-7131] Add connectionTimeout to avoid starvation

Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on issue #477: [AMQ-7131] Add connectionTimeout to avoid starvation
URL: https://github.com/apache/activemq/pull/477#issuecomment-591600804
 
 
   Yup exactly, extract the module into its own repo. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services