You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@gump.apache.org by ni...@apache.org on 2004/03/11 20:20:41 UTC
cvs commit: gump/blog/Issues Struts-Velocity.txt
nickchalko 2004/03/11 11:20:41
Added: blog/Issues Struts-Velocity.txt
Log:
Struts- Veleocity issue.
PR:
Obtained from:
Submitted by:
Reviewed by:
CVS: ----------------------------------------------------------------------
CVS: PR:
CVS: If this change addresses a PR in the problem report tracking
CVS: database, then enter the PR number(s) here.
CVS: Obtained from:
CVS: If this change has been taken from another system, such as NCSA,
CVS: then name the system in this line, otherwise delete it.
CVS: Submitted by:
CVS: If this code has been contributed to Apache by someone else; i.e.,
CVS: they sent us a patch or a new module, then include their name/email
CVS: address here. If this is your work then delete this line.
CVS: Reviewed by:
CVS: If we are doing pre-commit code reviews and someone else has
CVS: reviewed your changes, include their name(s) here.
CVS: If you have not had it reviewed then delete this line.
Revision Changes Path
1.1 gump/blog/Issues/Struts-Velocity.txt
Index: Struts-Velocity.txt
===================================================================
PREVIEW Struts broke an interface on a non-major version change (1.1 -> 1.2) and gump found it
View at
http://gump.chalko.com/gb/blog/Issues?permalink=STruts-Celocity.txt&preview=true&smm=y
<br/>
<p>
It looks like Struts broke an interface on a non-major version change (1.1 -> 1.2)
and
<a href="http://lsd.student.utwente.nl/gump/jakarta-velocity-tools/jakarta-velocity-tools.html"
>gump found it</a>. <more/>
Velocity is working with Struts community to show them that
what they are doing is harmful to client projects, and work out a compromise.
</p>
The specific compile errors were
<pre>
/data3/gump/jakarta-velocity-tools/src/java/org/apache/velocity/tools/struts/StrutsUtils.java:131: cannot resolve symbol
symbol : variable FORWARDS_KEY
location: class org.apache.struts.Globals
return (ActionForwards)app.getAttribute(Globals.FORWARDS_KEY);
^
/data3/gump/jakarta-velocity-tools/src/java/org/apache/velocity/tools/struts/StrutsUtils.java:146: cannot resolve symbol
symbol : class ActionForwards
location: class org.apache.velocity.tools.struts.StrutsUtils
ActionForwards forwards = getActionForwards(app);
^
/data3/gump/jakarta-velocity-tools/src/java/org/apache/velocity/tools/struts/StrutsUtils.java:164: cannot resolve symbol
symbol : class ActionMappings
location: class org.apache.velocity.tools.struts.StrutsUtils
return (ActionMappings)app.getAttribute(Globals.MAPPINGS_KEY);
^
/data3/gump/jakarta-velocity-tools/src/java/org/apache/velocity/tools/struts/StrutsUtils.java:164: cannot resolve symbol
symbol : variable MAPPINGS_KEY
location: class org.apache.struts.Globals
return (ActionMappings)app.getAttribute(Globals.MAPPINGS_KEY);
^
/data3/gump/jakarta-velocity-tools/src/java/org/apache/velocity/tools/struts/StrutsUtils.java:179: cannot resolve symbol
symbol : class ActionMappings
location: class org.apache.velocity.tools.struts.StrutsUtils
ActionMappings mappings = getActionMappings(app);
^
/data3/gump/jakarta-velocity-tools/src/java/org/apache/velocity/tools/struts/StrutsUtils.java:578: forwardURL(javax.servlet.http.HttpServletRequest,org.apache.struts.config.ForwardConfig,org.apache.struts.config.ModuleConfig) in org.apache.struts.util.RequestUtils cannot be applied to (javax.servlet.http.HttpServletRequest,org.apache.struts.config.ForwardConfig)
url.append(RequestUtils.forwardURL(request, fc));
^
</pre>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org
Re: cvs commit: gump/blog/Issues Struts-Velocity.txt
Posted by Stefano Mazzocchi <st...@apache.org>.
Martin Cooper wrote:
> On Thu, 11 Mar 2004, Nick Chalko wrote:
>
>
>>Is it premature to talk about this?
>>http://gump.chalko.com/gb/blog/Issues/?smm=y&permalink=Struts-Velocity.txt&preview=true
>>
>>I like to keep the visibility up. but is the risk of stepping on toes to
>>large?
>
>
> In principle, I don't mind this, but a couple of points to bear in mind:
>
> 1) The breakage happened 3 weeks and 6 days ago, but it was not until
> today that a message was sent to struts-dev informing us of the problem.
> We can't track all of the client projects, so if we break something,
> someone needs to let us know. It would be nice if that happened rather
> less than a month after the problem, because who knows what else might
> have happened in the code base since that change, making it that much
> harder to resolve. If the offending project is notified, and the problem
> persists for some period of time after that (more than a couple of days,
> but less than a month), *then* it is reasonable to go blog about it
> publicly. But please don't go posting about problems that the team either
> hasn't been notified of yet, or has only just heard about.
>
> 2) The wording in the blog entry is not exactly friendly, specifically the
> "show them what they are doing is harmful to client projects". This sounds
> like a parent scolding a naughty child. Yes, we know it's not good, but we
> didn't sit around and try to come up with ways to break Velocity-Tools. It
> was an accident, and we'll fix it.
You are right, the tone of the message is not helpful at all.
We must make a serious effort to show that gump is fostering
communication, not blaming and pointing fingers!!
Also, let's leave the people a break and report things when they are
solved not then they appear!!!
--
Stefano.
Re: cvs commit: gump/blog/Issues Struts-Velocity.txt
Posted by Stefan Bodewig <bo...@apache.org>.
On Thu, 11 Mar 2004, Martin Cooper <ma...@apache.org> wrote:
> 1) The breakage happened 3 weeks and 6 days ago, but it was not
> until today that a message was sent to struts-dev informing us of
> the problem. We can't track all of the client projects, so if we
> break something, someone needs to let us know.
I agree with you. velocity-tools has been failing for quite some time
now, and we could have told you.
While we are at it, there have also been build failues in Tomcat (I
think Tomcat 5) because of Struts interface changes. They don't
happen now since they are masked by a different build failure.
> But please don't go posting about problems that the team either
> hasn't been notified of yet, or has only just heard about.
+1
Thanks for looking into it
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org
Re: cvs commit: gump/blog/Issues Struts-Velocity.txt
Posted by "Adam R. B. Jack" <aj...@trysybase.com>.
Martin,
You make great points, and we apologize for over stepping the mark, it was
unintentional. We are trying to get into a habit of doing such postings, and
jumped the gun on this one. Also, we copied some content from a mailing list
posting, and failed to remove the 'intended humour' (which as you say --
comes across poorly in a public posting.)
Just a final note. We never meant anything by insulting by any of this.
Discontinuities happen, they are a fact of maturing/healthy code (where
folks have to fix older decisions) and they also happen simply by accident.
We know this, heck it happens to us, so please don't feel we were trying to
judge, we simple were over zealous.
BTW: We'll look into why the notification was late. Gump is trying to get
it's metadata healthy (so we get full builds every night, so we catch
discontinuities immediately) but we still have some work to do.
regards,
Adam
----- Original Message -----
From: "Martin Cooper" <ma...@apache.org>
To: "Gump code and data" <ge...@gump.apache.org>
Sent: Thursday, March 11, 2004 10:01 PM
Subject: Re: cvs commit: gump/blog/Issues Struts-Velocity.txt
> On Thu, 11 Mar 2004, Nick Chalko wrote:
>
> > Is it premature to talk about this?
> >
http://gump.chalko.com/gb/blog/Issues/?smm=y&permalink=Struts-Velocity.txt&preview=true
> >
> > I like to keep the visibility up. but is the risk of stepping on toes to
> > large?
>
> In principle, I don't mind this, but a couple of points to bear in mind:
>
> 1) The breakage happened 3 weeks and 6 days ago, but it was not until
> today that a message was sent to struts-dev informing us of the problem.
> We can't track all of the client projects, so if we break something,
> someone needs to let us know. It would be nice if that happened rather
> less than a month after the problem, because who knows what else might
> have happened in the code base since that change, making it that much
> harder to resolve. If the offending project is notified, and the problem
> persists for some period of time after that (more than a couple of days,
> but less than a month), *then* it is reasonable to go blog about it
> publicly. But please don't go posting about problems that the team either
> hasn't been notified of yet, or has only just heard about.
>
> 2) The wording in the blog entry is not exactly friendly, specifically the
> "show them what they are doing is harmful to client projects". This sounds
> like a parent scolding a naughty child. Yes, we know it's not good, but we
> didn't sit around and try to come up with ways to break Velocity-Tools. It
> was an accident, and we'll fix it.
>
> --
> Martin Cooper
>
>
> >
> > R,
> > Nick
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
> > For additional commands, e-mail: general-help@gump.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
> For additional commands, e-mail: general-help@gump.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org
Re: cvs commit: gump/blog/Issues Struts-Velocity.txt
Posted by Martin Cooper <ma...@apache.org>.
On Thu, 11 Mar 2004, Nick Chalko wrote:
> Is it premature to talk about this?
> http://gump.chalko.com/gb/blog/Issues/?smm=y&permalink=Struts-Velocity.txt&preview=true
>
> I like to keep the visibility up. but is the risk of stepping on toes to
> large?
In principle, I don't mind this, but a couple of points to bear in mind:
1) The breakage happened 3 weeks and 6 days ago, but it was not until
today that a message was sent to struts-dev informing us of the problem.
We can't track all of the client projects, so if we break something,
someone needs to let us know. It would be nice if that happened rather
less than a month after the problem, because who knows what else might
have happened in the code base since that change, making it that much
harder to resolve. If the offending project is notified, and the problem
persists for some period of time after that (more than a couple of days,
but less than a month), *then* it is reasonable to go blog about it
publicly. But please don't go posting about problems that the team either
hasn't been notified of yet, or has only just heard about.
2) The wording in the blog entry is not exactly friendly, specifically the
"show them what they are doing is harmful to client projects". This sounds
like a parent scolding a naughty child. Yes, we know it's not good, but we
didn't sit around and try to come up with ways to break Velocity-Tools. It
was an accident, and we'll fix it.
--
Martin Cooper
>
> R,
> Nick
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
> For additional commands, e-mail: general-help@gump.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org
Re: cvs commit: gump/blog/Issues Struts-Velocity.txt
Posted by Nick Chalko <ni...@chalko.com>.
Stefano Mazzocchi wrote:
> Nick Chalko wrote:
>
>> Is it premature to talk about this?
>> http://gump.chalko.com/gb/blog/Issues/?smm=y&permalink=Struts-Velocity.txt&preview=true
>>
>>
>> I like to keep the visibility up. but is the risk of stepping on toes
>> to large?
>
>
Reading it again I see that the people side of it came out harsh. I
will make sure to use softer words in the future.
> I think that it's fine if you remove the compiler error and keep it
> focused on the social aspect of things. [that is Stuts and Velocity
> have to work together to solve the issue]
>
I thought the compile error would be good for google and others facing
the same issues.
Given that I stepped on toes it is very important that we remeber to
blog about the success.
R,
Nick
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org
Re: cvs commit: gump/blog/Issues Struts-Velocity.txt
Posted by Stefano Mazzocchi <st...@apache.org>.
Nick Chalko wrote:
> Is it premature to talk about this?
> http://gump.chalko.com/gb/blog/Issues/?smm=y&permalink=Struts-Velocity.txt&preview=true
>
>
> I like to keep the visibility up. but is the risk of stepping on toes to
> large?
I think that it's fine if you remove the compiler error and keep it
focused on the social aspect of things. [that is Stuts and Velocity have
to work together to solve the issue]
This is the idea: talk about people, not code.
--
Stefano.
Re: cvs commit: gump/blog/Issues Struts-Velocity.txt
Posted by Nick Chalko <ni...@chalko.com>.
Is it premature to talk about this?
http://gump.chalko.com/gb/blog/Issues/?smm=y&permalink=Struts-Velocity.txt&preview=true
I like to keep the visibility up. but is the risk of stepping on toes to
large?
R,
Nick
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@gump.apache.org
For additional commands, e-mail: general-help@gump.apache.org