You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "terry0012 (via GitHub)" <gi...@apache.org> on 2023/07/11 13:36:50 UTC

[GitHub] [nuttx] terry0012 commented on a diff in pull request #9759: drivers/spi: add support for qspi hwfeatures

terry0012 commented on code in PR #9759:
URL: https://github.com/apache/nuttx/pull/9759#discussion_r1259751044


##########
include/nuttx/spi/qspi.h:
##########
@@ -271,6 +319,10 @@ struct qspi_ops_s
   CODE void      (*setmode)(FAR struct qspi_dev_s *dev,
                     enum qspi_mode_e mode);
   CODE void      (*setbits)(FAR struct qspi_dev_s *dev, int nbits);
+#ifdef CONFIG_QSPI_HWFEATURES
+  CODE int       (*hwfeatures)(FAR struct qspi_dev_s *dev,
+                    qspi_hwfeatures_t features);
+#endif

Review Comment:
   > Should we update all `struct qspi_ops_s` instances to add
   > 
   > ```
   > #ifdef CONFIG_QSPI_HWFEATURES
   >   , NULL
   > #endif
   > ```
   > 
   > ? Otherwise existing drivers will be broken
   
   OK, got it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org