[GitHub] [kafka] Hangleton commented on pull request #13558: KAFKA-14845: Fix broker registration with Zookeeper when the previous ephemeral znode was not properly recorded by the broker

["Hangleton (via GitHub)" <gi...@apache.org>]

Hangleton commented on PR #13558:
URL: https://github.com/apache/kafka/pull/13558#issuecomment-1552906809

   > Thank you for this PR.
   > 
   > Despite the detailed information in the PR description and JIRA (thank you!), I'm still unsure as to how this happens, and whether if it's a ZooKeeper bug we're mitigating against, or if there's something wrong about how we're using it. However, the proposed solution seems pretty innocuous.
   > 
   > I also wonder if some of the new test classes — `DelegatingRequest`, `InstrumentedRequestProcessor` and `InstrumentedZooKeeperServer` — would be better replaced by the use of mockito's `spy()`.
   
   Hi, Igor, thanks for reviewing the PR. I will get back to you with an update and follow-up on your feedback by EOD. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org