[superset] branch master updated: fix(embedded sdk): Remove trailing slash from passed superset domain if there is one (#25020)

[el...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

elizabeth pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 7402379346 fix(embedded sdk): Remove trailing slash from passed superset domain if there is one (#25020)
7402379346 is described below

commit 74023793464c131af005addc572d9b3aa7aa0898
Author: Jack Fragassi <jf...@gmail.com>
AuthorDate: Fri Aug 25 09:24:58 2023 -0700

    fix(embedded sdk): Remove trailing slash from passed superset domain if there is one (#25020)
---
 superset-embedded-sdk/package-lock.json | 4 ++--
 superset-embedded-sdk/package.json      | 2 +-
 superset-embedded-sdk/src/index.ts      | 4 ++++
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/superset-embedded-sdk/package-lock.json b/superset-embedded-sdk/package-lock.json
index 1ccf12d117..febe3b9ea5 100644
--- a/superset-embedded-sdk/package-lock.json
+++ b/superset-embedded-sdk/package-lock.json
@@ -1,12 +1,12 @@
 {
   "name": "@superset-ui/embedded-sdk",
-  "version": "0.1.0-alpha.9",
+  "version": "0.1.0-alpha.10",
   "lockfileVersion": 2,
   "requires": true,
   "packages": {
     "": {
       "name": "@superset-ui/embedded-sdk",
-      "version": "0.1.0-alpha.9",
+      "version": "0.1.0-alpha.10",
       "license": "Apache-2.0",
       "dependencies": {
         "@superset-ui/switchboard": "^0.18.26-0",
diff --git a/superset-embedded-sdk/package.json b/superset-embedded-sdk/package.json
index 1cab7f2c02..dfe1801ac9 100644
--- a/superset-embedded-sdk/package.json
+++ b/superset-embedded-sdk/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@superset-ui/embedded-sdk",
-  "version": "0.1.0-alpha.9",
+  "version": "0.1.0-alpha.10",
   "description": "SDK for embedding resources from Superset into your own application",
   "access": "public",
   "keywords": [
diff --git a/superset-embedded-sdk/src/index.ts b/superset-embedded-sdk/src/index.ts
index d2513422fa..a9ff0c485d 100644
--- a/superset-embedded-sdk/src/index.ts
+++ b/superset-embedded-sdk/src/index.ts
@@ -89,6 +89,10 @@ export async function embedDashboard({
 
   log('embedding');
 
+  if (supersetDomain.endsWith("/")) {
+    supersetDomain = supersetDomain.slice(0, -1);
+  }
+
   function calculateConfig() {
     let configNumber = 0
     if(dashboardUiConfig) {