You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@plc4x.apache.org by GitBox <gi...@apache.org> on 2022/11/09 10:20:09 UTC

[GitHub] [plc4x] ottlukas opened a new issue, #611: Mock driver always writes null value

ottlukas opened a new issue, #611:
URL: https://github.com/apache/plc4x/issues/611

   The Mock driver is usefull for developing applications without available hardware. Reads from Mock devices work, but writes seem broken.
   
   Scenario:
   
   implement *MockDevice* interface and the *write* method. See that this device is set in the connection using the *MockConnection*.*setDevice* method.
   
   When a WriteRequest is issued on the connection, the *MockDevice*.*write* method is indeed called, but the *value* parameter is always _*null*_. The given value to write is not passed through.
   
   Debugging and looking into the sourcecode shows following:
   
   *MockConnection.write* uses following statement to retrieve the value:
   
    
   ```
   
   // MockConnection:147
   ((MockField) writeRequest.getField(name)).getPlcValue()
   
   ```
   
   This retrieves the *plcValue* member from the MockField object. This  *plcValue* is written to by constructor *MockField(String address, MockPlcValue plcValue)* only. However, I did not find any call to this constructor.
   
    
   
   Note:
   
   Other Drivers seem to use
   ```
   
   writeRequest.getPlcValue(fieldName) 
   
   ```
   
   instead and do not have a value member in the Field class. (e.g. Simulator, Modbus )
   
   Imported from Jira [PLC4X-288](https://issues.apache.org/jira/browse/PLC4X-288). Original Jira may contain additional context.
   Reported by: teslanet-nl.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@plc4x.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Mock driver always writes null value

Posted by "ottlukas (via GitHub)" <gi...@apache.org>.
ottlukas commented on issue #611:
URL: https://github.com/apache/plc4x/issues/611#issuecomment-1929237099

   @chrisdutz  Our tests are running, so can this issue be closed now?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Mock driver always writes null value

Posted by "chrisdutz (via GitHub)" <gi...@apache.org>.
chrisdutz commented on issue #611:
URL: https://github.com/apache/plc4x/issues/611#issuecomment-1929480675

   Didn't close it, as I actually haven't tested it ... I did close an issue as it wasn't causing issues, till I noticed it wasn't as I disabled the test ... so wanted to make sure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@plc4x.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org