You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/11/24 21:35:37 UTC
[GitHub] [helix] jiajunwang opened a new pull request #1554: Fix TestStateTransitionAppFailureHandling by adding additional Null check.
jiajunwang opened a new pull request #1554:
URL: https://github.com/apache/helix/pull/1554
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
Resolve #1553
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
Since the test happens after a new cluster creating, it is possible that some of the initialization messages are removed during the test logic.
This may cause NPE in some race conditions. This change adds a check to avoid the Null from being checked.
### Tests
- [X] The following tests are written for this issue:
N/A
- [X] The following is the result of the "mvn test" command on the appropriate module:
The modified test passed. Please check the Github job result later on.
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on pull request #1554: Fix TestStateTransitionAppFailureHandling by adding additional Null check.
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on pull request #1554:
URL: https://github.com/apache/helix/pull/1554#issuecomment-733313457
The specific test case passed with no issue. Since there is no logic change, I will merge the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang merged pull request #1554: Fix TestStateTransitionAppFailureHandling by adding additional Null check.
Posted by GitBox <gi...@apache.org>.
jiajunwang merged pull request #1554:
URL: https://github.com/apache/helix/pull/1554
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org