[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #38: Enable spotbugs and fix high priority bugs

[GitBox <gi...@apache.org>]

jerqi commented on code in PR #38:
URL: https://github.com/apache/incubator-uniffle/pull/38#discussion_r916602185


##########
storage/src/main/java/org/apache/uniffle/storage/util/ShuffleStorageUtils.java:
##########
@@ -199,7 +200,7 @@ public static int[] getPartitionRange(int partitionId, int partitionNumPerRange,
 
   public static int getStorageIndex(int max, String appId, int shuffleId, int startPartition) {
     String hash = appId + "_" + shuffleId + "_" + startPartition;
-    int index = MurmurHash.getInstance().hash(hash.getBytes()) % max;
+    int index = MurmurHash.getInstance().hash(hash.getBytes(StandardCharsets.UTF_8)) % max;

Review Comment:
   Why do we need change this? This string only contain ASCII code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org