[GitHub] feng-tao closed pull request #4745: [bugfix] Fix the arguement order for security function

[GitBox <gi...@apache.org>]

feng-tao closed pull request #4745: [bugfix] Fix the arguement order for security function
URL: https://github.com/apache/incubator-superset/pull/4745
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/security.py b/superset/security.py
index e342b034d9..90a26fd1f8 100644
--- a/superset/security.py
+++ b/superset/security.py
@@ -211,7 +211,7 @@ def accessible_by_user(self, database, datasource_names, schema=None):
             full_names = {d.full_name for d in user_datasources}
             return [d for d in datasource_names if d in full_names]
 
-    def merge_perm(self, permission_name, view_menu_name):
+    def merge_perm(self, view_menu_name, permission_name):
         # Implementation copied from sm.find_permission_view_menu.
         # TODO: use sm.find_permission_view_menu once issue
         #       https://github.com/airbnb/superset/issues/1944 is resolved.


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services