[GitHub] [hbase] busbey commented on a change in pull request #662: HBASE-22942 move Snapshot verification to procedure

[GitBox <gi...@apache.org>]

busbey commented on a change in pull request #662: HBASE-22942 move Snapshot verification to procedure
URL: https://github.com/apache/hbase/pull/662#discussion_r329312522
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RestoreSnapshotProcedure.java
 ##########
 @@ -351,6 +352,12 @@ private void prepareRestore(final MasterProcedureEnv env) throws IOException {
         mfs.getFileSystem(),
         SnapshotDescriptionUtils.getCompletedSnapshotDir(snapshot, mfs.getRootDir()),
         snapshot);
+
+      // Verify snapshot validity
+      SnapshotReferenceUtil
 
 Review comment:
   This is currently in a block for only checking non-system tables. Needs to happen for all tables.
   
   Also should probably be the first thing we do in prepareRestore, since it used to proceed the step.
   
   Please update the status monitor about doing the verification as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services