You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by xunzhang <gi...@git.apache.org> on 2016/12/19 05:42:15 UTC
[GitHub] incubator-hawq pull request #1055: HAWQ-1001. Bugfix and refactor ranger log...
GitHub user xunzhang opened a pull request:
https://github.com/apache/incubator-hawq/pull/1055
HAWQ-1001. Bugfix and refactor ranger logic.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xunzhang/incubator-hawq HAWQ-1001-BUGFIX
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/1055.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1055
----
commit 3568cbfb790a196e555ed067d13a7483ee872f34
Author: xunzhang <xu...@gmail.com>
Date: 2016-12-19T05:08:23Z
HAWQ-1001. Bugfix and refactor ranger logic.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1055: HAWQ-1001. Bugfix and refactor ranger log...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1055#discussion_r92972825
--- Diff: src/backend/libpq/rangerrest.c ---
@@ -468,7 +440,7 @@ void call_ranger_rest(CURL_HANDLE curl_handle, char* request)
}
else
{
- elog(LOG, "%lu bytes retrieved from Ranger Restful API.",
+ elog(LOG, "%d bytes retrieved from Ranger Restful API.",
--- End diff --
It should be, but this pull request is just a hotfix and small refactor. I think ranger codes should be largely refactored later on which is not relevant to this pull request. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1055: HAWQ-1001. Bugfix and refactor ranger logic.
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on the issue:
https://github.com/apache/incubator-hawq/pull/1055
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1055: HAWQ-1001. Bugfix and refactor ranger logic.
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the issue:
https://github.com/apache/incubator-hawq/pull/1055
cc @linwen @ictmalili @zhangh43
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1055: HAWQ-1001. Bugfix and refactor ranger log...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1055#discussion_r92971978
--- Diff: src/backend/libpq/rangerrest.c ---
@@ -273,10 +245,10 @@ json_object *create_ranger_request_json_batch(List *args)
* }
*/
json_object* create_ranger_request_json(char* user, AclObjectKind kind, char* object,
- List* actions, char* how)
+ List* actions, bool how)
--- End diff --
Even change to bool, isn't another name better like is_*?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1055: HAWQ-1001. Bugfix and refactor ranger log...
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1055
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1055: HAWQ-1001. Bugfix and refactor ranger log...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1055#discussion_r92972165
--- Diff: src/backend/libpq/rangerrest.c ---
@@ -468,7 +440,7 @@ void call_ranger_rest(CURL_HANDLE curl_handle, char* request)
}
else
{
- elog(LOG, "%lu bytes retrieved from Ranger Restful API.",
+ elog(LOG, "%d bytes retrieved from Ranger Restful API.",
--- End diff --
Why not use size_t for size in struct?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1055: HAWQ-1001. Bugfix and refactor ranger logic.
Posted by xunzhang <gi...@git.apache.org>.
Github user xunzhang commented on the issue:
https://github.com/apache/incubator-hawq/pull/1055
Merged into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1055: HAWQ-1001. Bugfix and refactor ranger log...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1055#discussion_r92972130
--- Diff: src/backend/libpq/rangerrest.c ---
@@ -391,7 +363,7 @@ static size_t write_callback(char *contents, size_t size, size_t nitems,
void *userp)
{
size_t realsize = size * nitems;
- CURL_HANDLE curl = (struct curl_context *) userp;
+ CURL_HANDLE curl = (struct curl_context_t *) userp;
--- End diff --
Usually if a type have a _t in end, that means no struct is needed.
Either "struct curl_context" or curl_context_t.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1055: HAWQ-1001. Bugfix and refactor ranger log...
Posted by ictmalili <gi...@git.apache.org>.
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1055#discussion_r92971308
--- Diff: src/backend/libpq/rangerrest.c ---
@@ -273,10 +245,10 @@ json_object *create_ranger_request_json_batch(List *args)
* }
*/
json_object* create_ranger_request_json(char* user, AclObjectKind kind, char* object,
- List* actions, char* how)
+ List* actions, bool how)
--- End diff --
What do we pass for "how", why change it from char* to bool?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---